| Message ID | 20240819-add_sysmmu-v1-1-799c0f3f607f@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 71e0b08ed2a98e5ab5eb255fc86cda04205b141e |
| Headers | show |
| Series | arm64: dts: exynosautov9: Add dpum SysMMU | expand |
On 19/08/2024 09:55, Kwanghoon Son wrote: > Add System Memory Management Unit(SysMMU) for dpum also called iommu. > > This sysmmu is version 7.4, which has same functionality as exynos850. > > DPUM has 4 dma channel, each channel is mapped to one iommu. > > Signed-off-by: Kwanghoon Son <k.son@samsung.com> And droppped, this does not build. Best regards, Krzysztof
On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: > Add System Memory Management Unit(SysMMU) for dpum also called iommu. > > This sysmmu is version 7.4, which has same functionality as exynos850. > > DPUM has 4 dma channel, each channel is mapped to one iommu. > > > [...] Applied, thanks! [1/1] arm64: dts: exynosautov9: Add dpum SysMMU (no commit info) Best regards,
On 21/08/2024 13:28, Krzysztof Kozlowski wrote: > > On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: >> Add System Memory Management Unit(SysMMU) for dpum also called iommu. >> >> This sysmmu is version 7.4, which has same functionality as exynos850. >> >> DPUM has 4 dma channel, each channel is mapped to one iommu. >> >> >> [...] > > Applied, thanks! > > [1/1] arm64: dts: exynosautov9: Add dpum SysMMU > (no commit info) I should reply here - unapplied. Does not build. Best regards, Krzysztof
On Wed, 2024-08-21 at 13:29 +0200, Krzysztof Kozlowski wrote: > On 21/08/2024 13:28, Krzysztof Kozlowski wrote: > > > > On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: > > > Add System Memory Management Unit(SysMMU) for dpum also called iommu. > > > > > > This sysmmu is version 7.4, which has same functionality as exynos850. > > > > > > DPUM has 4 dma channel, each channel is mapped to one iommu. > > > > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] arm64: dts: exynosautov9: Add dpum SysMMU > > (no commit info) > > I should reply here - unapplied. Does not build. > > Best regards, > Krzysztof > I apologize for the inconvenience. This should come after https://lore.kernel.org/linux-samsung-soc/20240809-clk_dpum-v3-0-359decc30fe2@samsung.com/ patch (already merged in next) as 'next'. Would it be okay to you if I write 'next' on title and required patch in cover-letter? or anything more make you more easy to review. Kwang.
On 22/08/2024 04:16, Kwanghoon Son wrote: > On Wed, 2024-08-21 at 13:29 +0200, Krzysztof Kozlowski wrote: >> On 21/08/2024 13:28, Krzysztof Kozlowski wrote: >>> >>> On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: >>>> Add System Memory Management Unit(SysMMU) for dpum also called iommu. >>>> >>>> This sysmmu is version 7.4, which has same functionality as exynos850. >>>> >>>> DPUM has 4 dma channel, each channel is mapped to one iommu. >>>> >>>> >>>> [...] >>> >>> Applied, thanks! >>> >>> [1/1] arm64: dts: exynosautov9: Add dpum SysMMU >>> (no commit info) >> >> I should reply here - unapplied. Does not build. >> >> Best regards, >> Krzysztof >> > > I apologize for the inconvenience. > > This should come after > https://lore.kernel.org/linux-samsung-soc/20240809-clk_dpum-v3-0-359decc30fe2@samsung.com/ > patch (already merged in next) as 'next'. > > Would it be okay to you if I write 'next' on title and required patch > in cover-letter? or anything more make you more easy to review. 'next' has no meaning. It is impossible to apply patches on next. You should document the dependency in changelog or cover letter. Best regards, Krzysztof
On Thu, 2024-08-22 at 08:21 +0200, Krzysztof Kozlowski wrote: > On 22/08/2024 04:16, Kwanghoon Son wrote: > > On Wed, 2024-08-21 at 13:29 +0200, Krzysztof Kozlowski wrote: > > > On 21/08/2024 13:28, Krzysztof Kozlowski wrote: > > > > > > > > On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: > > > > > Add System Memory Management Unit(SysMMU) for dpum also called iommu. > > > > > > > > > > This sysmmu is version 7.4, which has same functionality as exynos850. > > > > > > > > > > DPUM has 4 dma channel, each channel is mapped to one iommu. > > > > > > > > > > > > > > > [...] > > > > > > > > Applied, thanks! > > > > > > > > [1/1] arm64: dts: exynosautov9: Add dpum SysMMU > > > > (no commit info) > > > > > > I should reply here - unapplied. Does not build. > > > > > > Best regards, > > > Krzysztof > > > > > > > I apologize for the inconvenience. > > > > This should come after > > https://lore.kernel.org/linux-samsung-soc/20240809-clk_dpum-v3-0-359decc30fe2@samsung.com/ > > patch (already merged in next) as 'next'. > > > > Would it be okay to you if I write 'next' on title and required patch > > in cover-letter? or anything more make you more easy to review. > > 'next' has no meaning. It is impossible to apply patches on next. > > You should document the dependency in changelog or cover letter. > > Best regards, > Krzysztof > Thanks, I'll follow guide when send v2. Kwang.
On Mon, 19 Aug 2024 16:55:45 +0900, Kwanghoon Son wrote: > Add System Memory Management Unit(SysMMU) for dpum also called iommu. > > This sysmmu is version 7.4, which has same functionality as exynos850. > > DPUM has 4 dma channel, each channel is mapped to one iommu. > > > [...] Applied, thanks! [1/1] arm64: dts: exynosautov9: Add dpum SysMMU https://git.kernel.org/krzk/linux/c/71e0b08ed2a98e5ab5eb255fc86cda04205b141e Best regards,
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index 599e72824875..b36292a7db64 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -261,6 +261,42 @@ cmu_dpum: clock-controller@18c00000 { clock-names = "oscclk", "bus"; }; + sysmmu_dpum_0: sysmmu@18c80000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x18c80000 0x10000>; + interrupts = <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_dpum CLK_GOUT_DPUM_SYSMMU_D0_CLK>; + clock-names = "sysmmu"; + #iommu-cells = <0>; + }; + + sysmmu_dpum_1: sysmmu@18c90000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x18c90000 0x10000>; + interrupts = <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_dpum CLK_GOUT_DPUM_SYSMMU_D1_CLK>; + clock-names = "sysmmu"; + #iommu-cells = <0>; + }; + + sysmmu_dpum_2: sysmmu@18ca0000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x18ca0000 0x10000>; + interrupts = <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_dpum CLK_GOUT_DPUM_SYSMMU_D2_CLK>; + clock-names = "sysmmu"; + #iommu-cells = <0>; + }; + + sysmmu_dpum_3: sysmmu@18cb0000 { + compatible = "samsung,exynos-sysmmu"; + reg = <0x18cb0000 0x10000>; + interrupts = <GIC_SPI 459 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu_dpum CLK_GOUT_DPUM_SYSMMU_D3_CLK>; + clock-names = "sysmmu"; + #iommu-cells = <0>; + }; + cmu_core: clock-controller@1b030000 { compatible = "samsung,exynosautov9-cmu-core"; reg = <0x1b030000 0x8000>;
Add System Memory Management Unit(SysMMU) for dpum also called iommu. This sysmmu is version 7.4, which has same functionality as exynos850. DPUM has 4 dma channel, each channel is mapped to one iommu. Signed-off-by: Kwanghoon Son <k.son@samsung.com> --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) --- base-commit: 367b5c3d53e57d51a5878816804652963da90950 change-id: 20240819-add_sysmmu-1a89611ddee4 Best regards,