| Message ID | 20240822075456.1370350-1-11162571@vivo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1] net:hidp:Use min macro | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
Sorry, please ignore this patch. Because the corresponding header file is not included, there may be compilation errors. 在 2024/8/22 15:54, Yang Ruibin 写道: > Instead of using the min() implementation of > the ternary operator, use real macros. > > Signed-off-by: Yang Ruibin <11162571@vivo.com> > --- > net/bluetooth/hidp/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c > index 707f229f8..7bf24f299 100644 > --- a/net/bluetooth/hidp/core.c > +++ b/net/bluetooth/hidp/core.c > @@ -294,7 +294,7 @@ static int hidp_get_raw_report(struct hid_device *hid, > > skb = session->report_return; > if (skb) { > - len = skb->len < count ? skb->len : count; > + len = min(skb->len, count); > memcpy(data, skb->data, len); > > kfree_skb(skb);
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c index 707f229f8..7bf24f299 100644 --- a/net/bluetooth/hidp/core.c +++ b/net/bluetooth/hidp/core.c @@ -294,7 +294,7 @@ static int hidp_get_raw_report(struct hid_device *hid, skb = session->report_return; if (skb) { - len = skb->len < count ? skb->len : count; + len = min(skb->len, count); memcpy(data, skb->data, len); kfree_skb(skb);
Instead of using the min() implementation of the ternary operator, use real macros. Signed-off-by: Yang Ruibin <11162571@vivo.com> --- net/bluetooth/hidp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)