Message ID | cover.1724315484.git.ps@pks.im (mailing list archive) |
---|---|
Headers | show
Received: from fout8-smtp.messagingengine.com (fout8-smtp.messagingengine.com [103.168.172.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F30441BF2A for <git@vger.kernel.org>; Thu, 22 Aug 2024 09:17:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.151 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724318235; cv=none; b=hjbZSsCcsK4m7D8zKxqxHs7BvCnDy5aHhwnwYgESWDmqX/ohxSGP7cjEuqFVjx95y2JIRuUP+l5XJwUDA8UB9Vf6K+g2g5Qyz07lXTj+K9mFNxg7vNVhTWKszKLjtUKLQwspsYKU9Nwg7YeJi1PpOkWiDsv7k09UKzsfbzK1Dn8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724318235; c=relaxed/simple; bh=sA0NlfOCOGrfMnVvDIduJXtp2cgHSRWwXq/wDTzZdkA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZOMu4yyd1irDOLncUQhZpHUKvuvgZnB0w95PmcwuyWeQqoi7vzlideuQHCJeMV3pU6MyA2wBA1tHXhOhWduYyIGohvOmwMM8DMn0V8CNvxyjYdYPvQdi+LGbMNj0JwIEQRxQ9D33TRmsl+vRi14xBR2Y3lEtDzudCge24S5uj7g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im; spf=pass smtp.mailfrom=pks.im; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b=UnVJye5H; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=OXZtVGzk; arc=none smtp.client-ip=103.168.172.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=pks.im Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pks.im Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pks.im header.i=@pks.im header.b="UnVJye5H"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="OXZtVGzk" Received: from phl-compute-08.internal (phl-compute-08.nyi.internal [10.202.2.48]) by mailfout.nyi.internal (Postfix) with ESMTP id 0AA82138FF75; Thu, 22 Aug 2024 05:17:12 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-08.internal (MEProxy); Thu, 22 Aug 2024 05:17:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1724318232; x=1724404632; bh=tbaX7BzxKf tcn/4191gZDNFoOezGlhkLIlgzF5W43bw=; b=UnVJye5HVZMRQ7vHmr+UJJu/oR t7gYxHfu7z0+ZsDzXTL3ffAjVpbjjhNyhCYY/3FRpI4FYpZGbSMpt/4GI6nTwiDN KQQ6F1TfCBzv6/NNkqaqMdVVXoDpcXWwfK9fT4MEfCzZnXHa545xo7aY7uWc4Ef+ dcThejLuMBpOmteHx4kxgMG7s2ldj0yEj8VDM6vEEJM4FoPzdrOhRqPLzf5q6j/q QTdSp/OUKgx+vix5+QpdXDINNL+Gd+uorpuDeNjW1T+GD0ekNJMwb56u4YnUoND6 2d9OuEHE/BSnigo4qOO0BsdCQ8jEQgCklH6VLHqlEOtkaodWZvPQA+bj7eWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1724318232; x=1724404632; bh=tbaX7BzxKftcn/4191gZDNFoOezG lhkLIlgzF5W43bw=; b=OXZtVGzkxn2GyvryjubIQ4f9rF3PxEBV6DJByzwCv6H0 FictECZr19jnAre1ekatxjgJ5QFNuKIkXfXocW+q/wlEoNOM/G6p73xipXBGR6z4 4znDQEMCdk2O96oZWYLtdcLJgHpYrDc7Lzc1P7rED3OTvE8488hmHJCiI7O9MA5z lsmFrDQ4JXhqHgaZjRF9isd3re0u5NNaPgPuy/+Mnp7rzwkx7HVjjeBSxFDqsuMS /rvHnRo8BvEDc3G+oMxC92gYawZNNLC/0FJdb4Z6bCFBMmKRQCVWapuKjvlrTcwp 8HfK7xkcybpb81XSj78Iww8OzAxotWTH1Ov9bggdZQ== X-ME-Sender: <xms:FwLHZhFIGqOhkx47Q7go5BZ0jlvjLnRR_50lQNARGcRRD_zOnOYbog> <xme:FwLHZmURkoSv4DgWIfnW39YCuWFBfQWyoB2qij8OBHUahA8n2wFjB2Z-bxQspWLvo 54derfltqEgs7ldbA> X-ME-Received: <xmr:FwLHZjJ-TkSRuwA-nZGCNdg_7oPwmHWeWhANryoKwN7VG5Rz1_okzGKQNQioo4k4QI_nayfkmV96LEka5xTcUN2jVxDKsZJO55NPmkVjgipT4sE> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddvtddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvve fukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefrrghtrhhitghkucfuthgvihhn hhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrhhnpedthfeiteevke eggeekleeiffehvdefieeggfevhfdthffghfeltdelgfdtieejheenucffohhmrghinhep hhhtthhprdhshhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehpshesphhkshdrihhmpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmthhp ohhuthdprhgtphhtthhopehgihhtsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpth htohepghhithhsthgvrhesphhosghogidrtghomh X-ME-Proxy: <xmx:FwLHZnETyJFiV1PMOjDhfmGl2OJKbAdCasZC13EQeoO1kuW1xIN--w> <xmx:FwLHZnWRF_qwc8eSyFKuAv6Y-JSFGh_ResEk2H5bgddLp7gIJzDFjQ> <xmx:FwLHZiOpercYjVP298BjvnTvh0ti9lsVuecclZpkEr-v70WN2ZOoXw> <xmx:FwLHZm0HEQx7BhRbwiHI1E5fx2zT4v8n5Py4KrvItHpxrdlVarpfaA> <xmx:FwLHZkh4FU579x7sDfwoafimGL7T2iX_MckOvM8GjaRRhXykQ9nc9jgw> Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Aug 2024 05:17:11 -0400 (EDT) Received: by vm-mail (OpenSMTPD) with ESMTPSA id 6088dacd (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 22 Aug 2024 09:16:35 +0000 (UTC) Date: Thu, 22 Aug 2024 11:17:08 +0200 From: Patrick Steinhardt <ps@pks.im> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com> Subject: [PATCH v2 00/20] Memory leak fixes (pt.5) Message-ID: <cover.1724315484.git.ps@pks.im> References: <cover.1724159575.git.ps@pks.im> Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: <git.vger.kernel.org> List-Subscribe: <mailto:git+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:git+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <cover.1724159575.git.ps@pks.im> |
Series |
Memory leak fixes (pt.5)
|
expand
|
Patrick Steinhardt <ps@pks.im> writes: > this is version 2 of this patch series that fixes another set of memory > leaks. > > Changes compared to v1: > > - Remove spaces between cast and variable. > > - Clarify why we move the `ctx.entries_nr` block. > > - Adapt sideband colors to use `git_config_get_string_tmp()` such that > we do not have to allocate the strings in the first place. > > - Fix more memory leaks for config values in the remote state. > > - Refactor `unbundle()` to not free extra args passed by the caller > anymore. Instead, this is now always done by the caler. All these changes look sensible to me. Let me wait for a few days for others' comments, and then mark the topic for 'next'. Thanks.