| Message ID | 20240823021257.1067054-1-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] arm64: dts: imx8mp-evk: Add native HDMI output | expand |
On Thu, Aug 22, 2024 at 11:12 PM Liu Ying <victor.liu@nxp.com> wrote: > + ports { > + port@1 { @1 without reg = <1>; will cause a warning.
On 08/23/2024, Fabio Estevam wrote: > On Thu, Aug 22, 2024 at 11:12 PM Liu Ying <victor.liu@nxp.com> wrote: > >> + ports { >> + port@1 { > > @1 without reg = <1>; will cause a warning. reg = <1>; is in arch/arm64/boot/dts/freescale/imx8mp.dtsi, so it is not needed here. I don't see any warning without reg = <1>; here. Do you see the warning you are claiming? If yes, can you paste the warning and what command do you use to trigger the warning?
On Thu, Aug 22, 2024 at 11:50 PM Liu Ying <victor.liu@nxp.com> wrote: > reg = <1>; is in arch/arm64/boot/dts/freescale/imx8mp.dtsi, > so it is not needed here. You are right. I haven't noticed it was part of imx8mp.dtsi. I ran 'make dtbs_check' and no warning is seen. Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hi, Am Freitag, 23. August 2024, 04:12:57 CEST schrieb Liu Ying: > J17 on i.MX8mp EVK base board is a HDMI type A connector. > It connects with i.MX8mp HDMI PHY. Add support for it. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > v2: > * Change label hdmi_out to hdmi_in. (Alexander) > > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 46 ++++++++++++++++++++ > 1 file changed, 46 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > index 938347704136..d26930f1a9e9 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts > @@ -56,6 +56,18 @@ memory@40000000 { > <0x1 0x00000000 0 0xc0000000>; > }; > > + native-hdmi-connector { > + compatible = "hdmi-connector"; > + label = "HDMI OUT"; > + type = "a"; > + > + port { > + hdmi_in: endpoint { > + remote-endpoint = <&hdmi_tx_out>; > + }; > + }; > + }; > + > pcie0_refclk: pcie0-refclk { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -408,6 +420,28 @@ &flexcan2 { > status = "disabled";/* can2 pin conflict with pdm */ > }; > > +&hdmi_pvi { > + status = "okay"; > +}; > + > +&hdmi_tx { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_hdmi>; > + status = "okay"; > + > + ports { > + port@1 { > + hdmi_tx_out: endpoint { > + remote-endpoint = <&hdmi_in>; > + }; > + }; > + }; > +}; > + > +&hdmi_tx_phy { > + status = "okay"; > +}; > + > &i2c1 { > clock-frequency = <400000>; > pinctrl-names = "default"; > @@ -604,6 +638,10 @@ &lcdif1 { > status = "okay"; > }; > > +&lcdif3 { > + status = "okay"; > +}; > + > &micfil { > #sound-dai-cells = <0>; > pinctrl-names = "default"; > @@ -858,6 +896,14 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 0x140 > >; > }; > > + pinctrl_hdmi: hdmigrp { > + fsl,pins = < > + MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x1c2 > + MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x1c2 > + MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x10 > + >; > + }; > + > pinctrl_hog: hoggrp { > fsl,pins = < > MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x40000010 >
On Fri, Aug 23, 2024 at 10:12:57AM +0800, Liu Ying wrote: > J17 on i.MX8mp EVK base board is a HDMI type A connector. > It connects with i.MX8mp HDMI PHY. Add support for it. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts index 938347704136..d26930f1a9e9 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts @@ -56,6 +56,18 @@ memory@40000000 { <0x1 0x00000000 0 0xc0000000>; }; + native-hdmi-connector { + compatible = "hdmi-connector"; + label = "HDMI OUT"; + type = "a"; + + port { + hdmi_in: endpoint { + remote-endpoint = <&hdmi_tx_out>; + }; + }; + }; + pcie0_refclk: pcie0-refclk { compatible = "fixed-clock"; #clock-cells = <0>; @@ -408,6 +420,28 @@ &flexcan2 { status = "disabled";/* can2 pin conflict with pdm */ }; +&hdmi_pvi { + status = "okay"; +}; + +&hdmi_tx { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_hdmi>; + status = "okay"; + + ports { + port@1 { + hdmi_tx_out: endpoint { + remote-endpoint = <&hdmi_in>; + }; + }; + }; +}; + +&hdmi_tx_phy { + status = "okay"; +}; + &i2c1 { clock-frequency = <400000>; pinctrl-names = "default"; @@ -604,6 +638,10 @@ &lcdif1 { status = "okay"; }; +&lcdif3 { + status = "okay"; +}; + &micfil { #sound-dai-cells = <0>; pinctrl-names = "default"; @@ -858,6 +896,14 @@ MX8MP_IOMUXC_NAND_READY_B__GPIO3_IO16 0x140 >; }; + pinctrl_hdmi: hdmigrp { + fsl,pins = < + MX8MP_IOMUXC_HDMI_DDC_SCL__HDMIMIX_HDMI_SCL 0x1c2 + MX8MP_IOMUXC_HDMI_DDC_SDA__HDMIMIX_HDMI_SDA 0x1c2 + MX8MP_IOMUXC_HDMI_CEC__HDMIMIX_HDMI_CEC 0x10 + >; + }; + pinctrl_hog: hoggrp { fsl,pins = < MX8MP_IOMUXC_HDMI_HPD__HDMIMIX_HDMI_HPD 0x40000010
J17 on i.MX8mp EVK base board is a HDMI type A connector. It connects with i.MX8mp HDMI PHY. Add support for it. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v2: * Change label hdmi_out to hdmi_in. (Alexander) arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 46 ++++++++++++++++++++ 1 file changed, 46 insertions(+)