diff mbox series

[1/4] nfsd: fix the comment of nfs_get_root

Message ID 20240823070049.3499625-2-lilingfeng3@huawei.com (mailing list archive)
State New
Headers show
Series nfsd: fix some comments and code cleanup | expand

Commit Message

Li Lingfeng Aug. 23, 2024, 7 a.m. UTC
The comment for nfs_get_root() needs to be updated as it would also be
used by NFS4 as follows:
@x[
    nfs_get_root+1
    nfs_get_tree_common+1819
    nfs_get_tree+2594
    vfs_get_tree+73
    fc_mount+23
    do_nfs4_mount+498
    nfs4_try_get_tree+134
    nfs_get_tree+2562
    vfs_get_tree+73
    path_mount+2776
    do_mount+226
    __se_sys_mount+343
    __x64_sys_mount+106
    do_syscall_64+69
    entry_SYSCALL_64_after_hwframe+97
, mount.nfs4]: 1

Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
---
 fs/nfs/getroot.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jeff Layton Aug. 23, 2024, 12:06 p.m. UTC | #1
On Fri, 2024-08-23 at 15:00 +0800, Li Lingfeng wrote:
> The comment for nfs_get_root() needs to be updated as it would also be
> used by NFS4 as follows:
> @x[
>     nfs_get_root+1
>     nfs_get_tree_common+1819
>     nfs_get_tree+2594
>     vfs_get_tree+73
>     fc_mount+23
>     do_nfs4_mount+498
>     nfs4_try_get_tree+134
>     nfs_get_tree+2562
>     vfs_get_tree+73
>     path_mount+2776
>     do_mount+226
>     __se_sys_mount+343
>     __x64_sys_mount+106
>     do_syscall_64+69
>     entry_SYSCALL_64_after_hwframe+97
> , mount.nfs4]: 1
> 
> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
> ---
>  fs/nfs/getroot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/getroot.c b/fs/nfs/getroot.c
> index 11ff2b2e060f..f13d25d95b85 100644
> --- a/fs/nfs/getroot.c
> +++ b/fs/nfs/getroot.c
> @@ -62,7 +62,7 @@ static int nfs_superblock_set_dummy_root(struct super_block *sb, struct inode *i
>  }
>  
>  /*
> - * get an NFS2/NFS3 root dentry from the root filehandle
> + * get a root dentry from the root filehandle
>   */
>  int nfs_get_root(struct super_block *s, struct fs_context *fc)
>  {

Note that this is a NFS client patch, not a nfsd patch like the title
suggests.

Acked-by: Jeff Layton <jlayton@kernel.org>
diff mbox series

Patch

diff --git a/fs/nfs/getroot.c b/fs/nfs/getroot.c
index 11ff2b2e060f..f13d25d95b85 100644
--- a/fs/nfs/getroot.c
+++ b/fs/nfs/getroot.c
@@ -62,7 +62,7 @@  static int nfs_superblock_set_dummy_root(struct super_block *sb, struct inode *i
 }
 
 /*
- * get an NFS2/NFS3 root dentry from the root filehandle
+ * get a root dentry from the root filehandle
  */
 int nfs_get_root(struct super_block *s, struct fs_context *fc)
 {