diff mbox series

[v3] drivers:ras:Use IS_ERR() to check debugfs_create_dir() return value

Message ID 20240823120147.3950878-1-11162571@vivo.com (mailing list archive)
State New
Headers show
Series [v3] drivers:ras:Use IS_ERR() to check debugfs_create_dir() return value | expand

Commit Message

Yang Ruibin Aug. 23, 2024, 12:01 p.m. UTC 
The debugfs_create_dir() function returns error pointers.It
never returns NULL. So use IS_ERR() to check its return value.

Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")
Signed-off-by: Yang Ruibin <11162571@vivo.com>
---
Changes V3:
-Fixed the wrong tiltle compared to V2.
---
 drivers/ras/cec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Borislav Petkov Aug. 23, 2024, 12:25 p.m. UTC | #1 
On Fri, Aug 23, 2024 at 08:01:47PM +0800, Yang Ruibin wrote:
> The debugfs_create_dir() function returns error pointers.It
> never returns NULL. So use IS_ERR() to check its return value.
> 
> Fixes: 011d82611172 ("RAS: Add a Corrected Errors Collector")

Nope, can't be that one:

$ git show 011d82611172:fs/debugfs/inode.c
...
struct dentry *debugfs_create_dir(const char *name, struct dentry *parent)
{
        struct dentry *dentry = start_creating(name, parent);
        struct inode *inode;

        if (IS_ERR(dentry))
                return NULL;
		       ^^^^
diff mbox series

Patch

diff --git a/drivers/ras/cec.c b/drivers/ras/cec.c
index e440b15fb..ebd4631b6 100644
--- a/drivers/ras/cec.c
+++ b/drivers/ras/cec.c
@@ -489,7 +489,7 @@  static int __init create_debugfs_nodes(void)
 	}
 
 	d = debugfs_create_dir("cec", dfs);
-	if (!d) {
+	if (IS_ERR(d)) {
 		pr_warn("Error creating cec debugfs node!\n");
 		return -1;
 	}