| Message ID | 20240823124239.2263107-1-catalin.popescu@leica-geosystems.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next,1/2] dt-bindings: net: bluetooth: nxp: support multiple init baudrates | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Fri, 23 Aug 2024 14:42:38 +0200, Catalin Popescu wrote: > Make "fw-init-baudrate" a list of baudrates in order to support chips > using different baudrates assuming that we could not detect the > supported baudrate otherwise. > > Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml: properties:fw-init-baudrate:maxItems: False schema does not allow 8 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240823124239.2263107-1-catalin.popescu@leica-geosystems.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Aug 23, 2024 at 02:42:38PM +0200, Catalin Popescu wrote: > Make "fw-init-baudrate" a list of baudrates in order to support chips > using different baudrates assuming that we could not detect the > supported baudrate otherwise. > > Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> > --- > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > index 37a65badb448..42e3713927de 100644 > --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > @@ -25,11 +25,12 @@ properties: > > fw-init-baudrate: > $ref: /schemas/types.yaml#/definitions/uint32 > + maxItems: 8 > default: 115200 > description: > - Chip baudrate after FW is downloaded and initialized. > - This property depends on the module vendor's > - configuration. > + List of chip baudrates after FW is downloaded and initialized. > + The driver goes through the list until it founds a working baudrate. > + This property depends on the module vendor's configuration. > You need to test your patch... and update the example and explain why changing from 1 to 8 items (so ABI break) is okay or needed. But even without updating the example, you would see errors when testing DTS, so this was never tested. :/ Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml index 37a65badb448..42e3713927de 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml @@ -25,11 +25,12 @@ properties: fw-init-baudrate: $ref: /schemas/types.yaml#/definitions/uint32 + maxItems: 8 default: 115200 description: - Chip baudrate after FW is downloaded and initialized. - This property depends on the module vendor's - configuration. + List of chip baudrates after FW is downloaded and initialized. + The driver goes through the list until it founds a working baudrate. + This property depends on the module vendor's configuration. firmware-name: maxItems: 1
Make "fw-init-baudrate" a list of baudrates in order to support chips using different baudrates assuming that we could not detect the supported baudrate otherwise. Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com> --- .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) base-commit: c79c85875f1af04040fe4492ed94ce37ad729c4d prerequisite-patch-id: 0000000000000000000000000000000000000000