mbox series

[RESEND,v8,0/2] mm: store zero pages to be swapped out in a bitmap

Message ID 20240823190545.979059-1-usamaarif642@gmail.com (mailing list archive)
Headers show
Series mm: store zero pages to be swapped out in a bitmap | expand

Message

Usama Arif Aug. 23, 2024, 7:04 p.m. UTC 
Resending it, as the CC had "Huang, Ying" in one of the initial patches,
and it was rejected by git send-email because of the "," in name.

The original series [1] was almost merged, but was dropped
due to a last minute bug [2]. Resending this with the fix for it,
by handling zeromap in the same way as swap_map and cluster_info in
enable_swap_info, holding swapon_mutex and si->lock, hence avoiding
a race condition between swapon and any point where the lock is held. 
This is the safest way.

The series had already been reviewed and acked by all maintainers.

Hoping that this attempt goes better than the initial one :)

This patchseries is based on mm-unstable from today:
4926e8348e10 - (akpm/mm-unstable) mm: optimization on page allocation when CMA enabled

[1] https://lore.kernel.org/all/20240627105730.3110705-1-usamaarif642@gmail.com/
[2] https://lore.kernel.org/all/202407101031.c6c3c651-lkp@intel.com/

Usama Arif (2):
  mm: store zero pages to be swapped out in a bitmap
  mm: remove code to handle same filled pages

 include/linux/swap.h |   1 +
 mm/page_io.c         | 118 ++++++++++++++++++++++++++++++++++++++++++-
 mm/swapfile.c        |  38 ++++++++++++--
 mm/zswap.c           |  85 +++----------------------------
 4 files changed, 159 insertions(+), 83 deletions(-)

Comments

Andrew Morton Aug. 24, 2024, 5:06 a.m. UTC | #1 
On Fri, 23 Aug 2024 20:04:38 +0100 Usama Arif <usamaarif642@gmail.com> wrote:

> Resending it, as the CC had "Huang, Ying" in one of the initial patches,
> and it was rejected by git send-email because of the "," in name.
> 
> The original series [1] was almost merged, but was dropped
> due to a last minute bug [2]. Resending this with the fix for it,
> by handling zeromap in the same way as swap_map and cluster_info in
> enable_swap_info, holding swapon_mutex and si->lock, hence avoiding
> a race condition between swapon and any point where the lock is held. 
> This is the safest way.
> 
> The series had already been reviewed and acked by all maintainers.
> 
> Hoping that this attempt goes better than the initial one :)

Yup ;)

We're missing the [0/n] words here.  I pasted the text from the v1
series.  Please check that it remains the truth, the whole truth and
nothing but the truth.
Usama Arif Aug. 24, 2024, 6:47 p.m. UTC | #2 
On 24/08/2024 01:06, Andrew Morton wrote:
> On Fri, 23 Aug 2024 20:04:38 +0100 Usama Arif <usamaarif642@gmail.com> wrote:
> 
>> Resending it, as the CC had "Huang, Ying" in one of the initial patches,
>> and it was rejected by git send-email because of the "," in name.
>>
>> The original series [1] was almost merged, but was dropped
>> due to a last minute bug [2]. Resending this with the fix for it,
>> by handling zeromap in the same way as swap_map and cluster_info in
>> enable_swap_info, holding swapon_mutex and si->lock, hence avoiding
>> a race condition between swapon and any point where the lock is held. 
>> This is the safest way.
>>
>> The series had already been reviewed and acked by all maintainers.
>>
>> Hoping that this attempt goes better than the initial one :)
> 
> Yup ;)
> 
> We're missing the [0/n] words here.  I pasted the text from the v1
> series.  Please check that it remains the truth, the whole truth and
> nothing but the truth.

Yes, Thanks! The cover letter remains the same.