diff mbox series

[-next,v2] lib/string_choices: Add str_true_false()/str_false_true() helper

Message ID 20240824070950.2014859-1-lihongbo22@huawei.com (mailing list archive)
State Mainlined
Commit 6ff4cd1160afafc12ad1603e3d2f39256e4b708d
Headers show
Series [-next,v2] lib/string_choices: Add str_true_false()/str_false_true() helper | expand

Commit Message

Hongbo Li Aug. 24, 2024, 7:09 a.m. UTC
Add str_true_false()/str_false_true() helper to return "true" or
"false" string literal.

Signed-off-by: Hongbo Li <lihongbo22@huawei.com>

---
v2:
  - Squash into a single patch as Andy Shevchenko' suggesstion.

v1:
  - https://lore.kernel.org/all/1deb2bc4-0cd1-41a0-9434-65c02eef77ed@huawei.com/T/
---
 include/linux/string_choices.h | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Hongbo Li Aug. 24, 2024, 7:04 a.m. UTC | #1
As discussed in the previous thread, the coccinelle rules and some 
replacements will be added in the future.

Thanks,
Hongbo

On 2024/8/24 15:09, Hongbo Li wrote:
> Add str_true_false()/str_false_true() helper to return "true" or
> "false" string literal.
> 
> Signed-off-by: Hongbo Li <lihongbo22@huawei.com>
> 
> ---
> v2:
>    - Squash into a single patch as Andy Shevchenko' suggesstion.
> 
> v1:
>    - https://lore.kernel.org/all/1deb2bc4-0cd1-41a0-9434-65c02eef77ed@huawei.com/T/
> ---
>   include/linux/string_choices.h | 6 ++++++
>   1 file changed, 6 insertions(+)
> 
> diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h
> index 1320bcdcb89c..ebcc56b28ede 100644
> --- a/include/linux/string_choices.h
> +++ b/include/linux/string_choices.h
> @@ -48,6 +48,12 @@ static inline const char *str_up_down(bool v)
>   }
>   #define str_down_up(v)		str_up_down(!(v))
>   
> +static inline const char *str_true_false(bool v)
> +{
> +	return v ? "true" : "false";
> +}
> +#define str_false_true(v)		str_true_false(!(v))
> +
>   /**
>    * str_plural - Return the simple pluralization based on English counts
>    * @num: Number used for deciding pluralization
Greg Kroah-Hartman Aug. 24, 2024, 9:18 a.m. UTC | #2
On Sat, Aug 24, 2024 at 03:04:52PM +0800, Hongbo Li wrote:
> As discussed in the previous thread, the coccinelle rules and some
> replacements will be added in the future.

Then we have to wait for this one until then.  Remember, we can not take
functions that no one calls, as they will be noticed and someone will
remove them.

Please make a patch series with the function being used, that's the only
way we can actually determine if the addition is correct or not.

thanks,

greg k-h
diff mbox series

Patch

diff --git a/include/linux/string_choices.h b/include/linux/string_choices.h
index 1320bcdcb89c..ebcc56b28ede 100644
--- a/include/linux/string_choices.h
+++ b/include/linux/string_choices.h
@@ -48,6 +48,12 @@  static inline const char *str_up_down(bool v)
 }
 #define str_down_up(v)		str_up_down(!(v))
 
+static inline const char *str_true_false(bool v)
+{
+	return v ? "true" : "false";
+}
+#define str_false_true(v)		str_true_false(!(v))
+
 /**
  * str_plural - Return the simple pluralization based on English counts
  * @num: Number used for deciding pluralization