| Message ID | 20240826134656.94892-1-djahchankoike@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3d6a0c4f4552c8b08ba63b9da97c8255db4c6a56 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,v2] net: fix unreleased lock in cable test | expand |
Hi, Thanks for addressing this, I was unavailable in the past hours to quicky respond to the issue so your help is welcome :) On Mon, 26 Aug 2024 10:45:46 -0300 Diogo Jahchan Koike <djahchankoike@gmail.com> wrote: > fix an unreleased lock in out_dev_put path by removing the (now) > unnecessary path. > > Reported-by: syzbot+c641161e97237326ea74@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=c641161e97237326ea74 > Fixes: 3688ff3077d3 ("net: ethtool: cable-test: Target the command to the requested PHY") > Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> Thanks, Maxime
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 26 Aug 2024 10:45:46 -0300 you wrote: > fix an unreleased lock in out_dev_put path by removing the (now) > unnecessary path. > > Reported-by: syzbot+c641161e97237326ea74@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=c641161e97237326ea74 > Fixes: 3688ff3077d3 ("net: ethtool: cable-test: Target the command to the requested PHY") > Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com> > > [...] Here is the summary with links: - [net-next,v2] net: fix unreleased lock in cable test https://git.kernel.org/netdev/net-next/c/3d6a0c4f4552 You are awesome, thank you!
diff --git a/net/ethtool/cabletest.c b/net/ethtool/cabletest.c index 01db8f394869..8c5aa63cb1aa 100644 --- a/net/ethtool/cabletest.c +++ b/net/ethtool/cabletest.c @@ -77,7 +77,7 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info) info->extack); if (IS_ERR_OR_NULL(phydev)) { ret = -EOPNOTSUPP; - goto out_dev_put; + goto out_rtnl; } ops = ethtool_phy_ops; @@ -99,7 +99,6 @@ int ethnl_act_cable_test(struct sk_buff *skb, struct genl_info *info) out_rtnl: rtnl_unlock(); -out_dev_put: ethnl_parse_header_dev_put(&req_info); return ret; }
fix an unreleased lock in out_dev_put path by removing the (now) unnecessary path. Reported-by: syzbot+c641161e97237326ea74@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c641161e97237326ea74 Fixes: 3688ff3077d3 ("net: ethtool: cable-test: Target the command to the requested PHY") Signed-off-by: Diogo Jahchan Koike <djahchankoike@gmail.com> --- net/ethtool/cabletest.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)