| Message ID | 20240822192758.141201-1-rosenp@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d2ab3bb890f6a88facf89494ce50b27ff8236d24 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ag71xx: move clk_eth out of struct | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 22 Aug 2024 12:27:52 -0700 you wrote: > It's only used in one place. It doesn't need to be in the struct. > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > drivers/net/ethernet/atheros/ag71xx.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Here is the summary with links: - [net-next] net: ag71xx: move clk_eth out of struct https://git.kernel.org/netdev/net-next/c/d2ab3bb890f6 You are awesome, thank you!
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c index 95da34c71b34..89cd001b385f 100644 --- a/drivers/net/ethernet/atheros/ag71xx.c +++ b/drivers/net/ethernet/atheros/ag71xx.c @@ -381,7 +381,6 @@ struct ag71xx { struct reset_control *mdio_reset; struct clk *clk_mdio; - struct clk *clk_eth; }; static int ag71xx_desc_empty(struct ag71xx_desc *desc) @@ -1801,6 +1800,7 @@ static int ag71xx_probe(struct platform_device *pdev) const struct ag71xx_dcfg *dcfg; struct net_device *ndev; struct resource *res; + struct clk *clk_eth; int tx_size, err, i; struct ag71xx *ag; @@ -1831,10 +1831,10 @@ static int ag71xx_probe(struct platform_device *pdev) return -EINVAL; } - ag->clk_eth = devm_clk_get_enabled(&pdev->dev, "eth"); - if (IS_ERR(ag->clk_eth)) { + clk_eth = devm_clk_get_enabled(&pdev->dev, "eth"); + if (IS_ERR(clk_eth)) { netif_err(ag, probe, ndev, "Failed to get eth clk.\n"); - return PTR_ERR(ag->clk_eth); + return PTR_ERR(clk_eth); } SET_NETDEV_DEV(ndev, &pdev->dev);
It's only used in one place. It doesn't need to be in the struct. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- drivers/net/ethernet/atheros/ag71xx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)