| Message ID | SN6PR01MB50705B846790BE05B92FDE7CA58B2@SN6PR01MB5070.prod.exchangelabs.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btusb: Add USB HW IDs for MT7925 | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | fail | error: patch failed: drivers/bluetooth/btusb.c:690 error: drivers/bluetooth/btusb.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch |
This is an automated email and please do not reply to this email. Dear Submitter, Thank you for submitting the patches to the linux bluetooth mailing list. While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository. ----- Output ----- error: patch failed: drivers/bluetooth/btusb.c:690 error: drivers/bluetooth/btusb.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch Please resolve the issue and submit the patches again. --- Regards, Linux Bluetooth
Dear Michael, Thank you for your patch. Adding Jiande to Cc. You could make the commit message slightly more specific: Add 2 USB HW IDs for MT7925 or Add 2 USB HW IDs for MT7925 (0xe118/e) Am 26.08.24 um 20:06 schrieb Michael Burch: > Add HW IDs for wireless module specific to ASUS > notebook model to ensure proper recognition and functionality. > These HW IDs are extracted from Windows driver inf file. Please add the URL to the commit message. Were you able to test this on a device? If yes, please document that too. (I’d also re-flow the commit message, so the first line is longer.) > Signed-off-by: Michael Burch <me@michaelburch.net> > --- > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index 51d9d4532dda..d712f5acc338 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -690,6 +690,12 @@ static const struct usb_device_id quirks_table[] = { > { USB_DEVICE(0x0489, 0xe113), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x0489, 0xe118), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > + { USB_DEVICE(0x0489, 0xe11e), .driver_info = BTUSB_MEDIATEK | > + BTUSB_WIDEBAND_SPEECH | > + BTUSB_VALID_LE_STATES }, > { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK | > BTUSB_WIDEBAND_SPEECH | > BTUSB_VALID_LE_STATES }, Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index 51d9d4532dda..d712f5acc338 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -690,6 +690,12 @@ static const struct usb_device_id quirks_table[] = { { USB_DEVICE(0x0489, 0xe113), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x0489, 0xe118), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, + { USB_DEVICE(0x0489, 0xe11e), .driver_info = BTUSB_MEDIATEK | + BTUSB_WIDEBAND_SPEECH | + BTUSB_VALID_LE_STATES }, { USB_DEVICE(0x13d3, 0x3602), .driver_info = BTUSB_MEDIATEK | BTUSB_WIDEBAND_SPEECH | BTUSB_VALID_LE_STATES },
Add HW IDs for wireless module specific to ASUS notebook model to ensure proper recognition and functionality. These HW IDs are extracted from Windows driver inf file. Signed-off-by: Michael Burch <me@michaelburch.net> ---