| Message ID | 20240814-b4-cleanup-h-of-node-put-usb-v1-8-95481b9682bc@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 17d206a3687ec662b0eb7c1f083fb8abd29842be |
| Headers | show |
| Series | usb: dwc3: various cleanups | expand |
On Wed, Aug 14, 2024, Krzysztof Kozlowski wrote: > Use devm_platform_ioremap_resource() wrapper instead of two calls. This > allows also dropping local 'res' variable. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/usb/dwc3/dwc3-qcom.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index 03a8f080078e..c1d4b52f25b0 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c > @@ -735,7 +735,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > struct device_node *np = pdev->dev.of_node; > struct device *dev = &pdev->dev; > struct dwc3_qcom *qcom; > - struct resource *res; > int ret, i; > bool ignore_pipe_clk; > bool wakeup_source; > @@ -773,9 +772,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) > goto reset_assert; > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - > - qcom->qscratch_base = devm_ioremap_resource(dev, res); > + qcom->qscratch_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(qcom->qscratch_base)) { > ret = PTR_ERR(qcom->qscratch_base); > goto clk_disable; > > -- > 2.43.0 > Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Thanks, Thinh
diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 03a8f080078e..c1d4b52f25b0 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -735,7 +735,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) struct device_node *np = pdev->dev.of_node; struct device *dev = &pdev->dev; struct dwc3_qcom *qcom; - struct resource *res; int ret, i; bool ignore_pipe_clk; bool wakeup_source; @@ -773,9 +772,7 @@ static int dwc3_qcom_probe(struct platform_device *pdev) goto reset_assert; } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - - qcom->qscratch_base = devm_ioremap_resource(dev, res); + qcom->qscratch_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(qcom->qscratch_base)) { ret = PTR_ERR(qcom->qscratch_base); goto clk_disable;
Use devm_platform_ioremap_resource() wrapper instead of two calls. This allows also dropping local 'res' variable. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/usb/dwc3/dwc3-qcom.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)