mbox series

[for,stable,0/2] ASoC: topology: Fix loading topology issue

Message ID 20240814140657.2369433-1-amadeuszx.slawinski@linux.intel.com (mailing list archive)
Headers show
Series ASoC: topology: Fix loading topology issue | expand

Message

Amadeusz Sławiński Aug. 14, 2024, 2:06 p.m. UTC
Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
is a problematic fix for issue in topology loading code, which was
cherry-picked to stable. It was later corrected in
0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
also needs to be applied.

Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19

Amadeusz Sławiński (2):
  ASoC: topology: Clean up route loading
  ASoC: topology: Fix route memory corruption

 sound/soc/soc-topology.c | 32 ++++++++------------------------
 1 file changed, 8 insertions(+), 24 deletions(-)


base-commit: 878fbff41def4649a2884e9d33bb423f5a7726b0

Comments

Greg KH Aug. 14, 2024, 2:12 p.m. UTC | #1
On Wed, Aug 14, 2024 at 04:06:55PM +0200, Amadeusz Sławiński wrote:
> Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
> is a problematic fix for issue in topology loading code, which was
> cherry-picked to stable. It was later corrected in
> 0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
> apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
> also needs to be applied.
> 
> Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19
> 
> Amadeusz Sławiński (2):
>   ASoC: topology: Clean up route loading
>   ASoC: topology: Fix route memory corruption
> 
>  sound/soc/soc-topology.c | 32 ++++++++------------------------
>  1 file changed, 8 insertions(+), 24 deletions(-)
> 
> 
> base-commit: 878fbff41def4649a2884e9d33bb423f5a7726b0
> -- 
> 2.34.1
> 
> 

What stable tree(s) is this for?
Amadeusz Sławiński Aug. 14, 2024, 2:19 p.m. UTC | #2
On 8/14/2024 4:12 PM, Greg Kroah-Hartman wrote:
> On Wed, Aug 14, 2024 at 04:06:55PM +0200, Amadeusz Sławiński wrote:
>> Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
>> is a problematic fix for issue in topology loading code, which was
>> cherry-picked to stable. It was later corrected in
>> 0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
>> apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
>> also needs to be applied.
>>
>> Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19
>>
>> Amadeusz Sławiński (2):
>>    ASoC: topology: Clean up route loading
>>    ASoC: topology: Fix route memory corruption
>>
>>   sound/soc/soc-topology.c | 32 ++++++++------------------------
>>   1 file changed, 8 insertions(+), 24 deletions(-)
>>
>>
>> base-commit: 878fbff41def4649a2884e9d33bb423f5a7726b0
>> -- 
>> 2.34.1
>>
>>
> 
> What stable tree(s) is this for?

For whichever one has 97ab304ecd95 ("ASoC: topology: Fix references to 
freed memory") applied and doesn't have following patches, as far as I 
can tell:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound?h=v6.9.12
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound/soc?h=v6.6.46
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound/soc?h=v6.1.105

should I send separate mail for each?
Greg KH Aug. 14, 2024, 2:49 p.m. UTC | #3
On Wed, Aug 14, 2024 at 04:19:06PM +0200, Amadeusz Sławiński wrote:
> On 8/14/2024 4:12 PM, Greg Kroah-Hartman wrote:
> > On Wed, Aug 14, 2024 at 04:06:55PM +0200, Amadeusz Sławiński wrote:
> > > Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
> > > is a problematic fix for issue in topology loading code, which was
> > > cherry-picked to stable. It was later corrected in
> > > 0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
> > > apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
> > > also needs to be applied.
> > > 
> > > Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19
> > > 
> > > Amadeusz Sławiński (2):
> > >    ASoC: topology: Clean up route loading
> > >    ASoC: topology: Fix route memory corruption
> > > 
> > >   sound/soc/soc-topology.c | 32 ++++++++------------------------
> > >   1 file changed, 8 insertions(+), 24 deletions(-)
> > > 
> > > 
> > > base-commit: 878fbff41def4649a2884e9d33bb423f5a7726b0
> > > -- 
> > > 2.34.1
> > > 
> > > 
> > 
> > What stable tree(s) is this for?
> 
> For whichever one has 97ab304ecd95 ("ASoC: topology: Fix references to freed
> memory") applied and doesn't have following patches, as far as I can tell:
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound?h=v6.9.12
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound/soc?h=v6.6.46
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/log/sound/soc?h=v6.1.105
> 
> should I send separate mail for each?

If they do not apply cleanly to all of them, yes.  If not, no.

Please resend these anyway, with the proper git id info so we don't have
to hand paste them in.

thanks,

greg k-h
Greg KH Aug. 27, 2024, 1:11 p.m. UTC | #4
On Wed, Aug 14, 2024 at 04:06:55PM +0200, Amadeusz Sławiński wrote:
> Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
> is a problematic fix for issue in topology loading code, which was
> cherry-picked to stable. It was later corrected in
> 0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
> apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
> also needs to be applied.
> 
> Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19

You need to put the git ids in the patches directly do we have a clue
what to do.

Also, what tree(s) do you need/want these in?

Please fix up and resend.

thanks,

greg k-h
Amadeusz Sławiński Aug. 27, 2024, 1:23 p.m. UTC | #5
On 8/27/2024 3:11 PM, Greg Kroah-Hartman wrote:
> On Wed, Aug 14, 2024 at 04:06:55PM +0200, Amadeusz Sławiński wrote:
>> Commit 97ab304ecd95 ("ASoC: topology: Fix references to freed memory")
>> is a problematic fix for issue in topology loading code, which was
>> cherry-picked to stable. It was later corrected in
>> 0298f51652be ("ASoC: topology: Fix route memory corruption"), however to
>> apply cleanly e0e7bc2cbee9 ("ASoC: topology: Clean up route loading")
>> also needs to be applied.
>>
>> Link: https://lore.kernel.org/linux-sound/ZrwUCnrtKQ61LWFS@sashalap/T/#mbfd273adf86fe93b208721f1437d36e5d2a9aa19
> 
> You need to put the git ids in the patches directly do we have a clue
> what to do.
> 
> Also, what tree(s) do you need/want these in?
> 
> Please fix up and resend.
> 

I've already send v2 and as far as I know it was merged.

Here is link to v2:
https://lore.kernel.org/linux-sound/2024081442-thimble-widget-e370@gregkh/T/#t