| Message ID | 20240824143837.228874-1-david.hunter.linux@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Commit | 39e8111ce5ce76039a80eaf6dd71ae8bb6866f95 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/1,V2] Selftests: net: Set executable bit for shell script | expand |
Hello: This patch was applied to netdev/net-next.git (main) by Martin KaFai Lau <martin.lau@kernel.org>: On Sat, 24 Aug 2024 10:38:37 -0400 you wrote: > Turn on the execution bit for the shell script file. The test is skipped > when downloaded from the linux_mainline source files. > > Signed-off-by: David Hunter <david.hunter.linux@gmail.com> > --- > V1 --> V2 > - Split the patch into two separate patches (one for each issue) > - Included subject prefixes > > [...] Here is the summary with links: - [1/1,V2] Selftests: net: Set executable bit for shell script https://git.kernel.org/netdev/net-next/c/39e8111ce5ce You are awesome, thank you!
On Sat, 24 Aug 2024 10:38:37 -0400 David Hunter wrote: > Subject: [PATCH 1/1 V2] Selftests: net: Set executable bit for shell script no need to capitalize Selftests > Turn on the execution bit for the shell script file. The test is skipped > when downloaded from the linux_mainline source files. Change makes sense but I don't understand the commit message. What is linux_mainline and how does one download from it? I see an Arch package with similar name is that what you mean? BTW ignore the pw-bot it gets confused by mode changes
From: david.hunter.linux@gmail.com On Mon, 26 Aug 2024 14:40:22 -0700 Jakub Kicinski wrote: > What is linux_mainline and how does one download from it? The Linux Mainline source files can be downloaded using the following command: git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux_mainline I meant to say "Linux Mainline". In my computer, I put the title for the directory as "linux_mainline", so I have a habit of putting the underscore when I should not.
On Tue, 27 Aug 2024 17:37:21 -0400 David Hunter wrote: > On Mon, 26 Aug 2024 14:40:22 -0700 Jakub Kicinski wrote: > > What is linux_mainline and how does one download from it? > > The Linux Mainline source files can be downloaded using the following command: > > git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git linux_mainline > > I meant to say "Linux Mainline". In my computer, I put the title for > the directory as "linux_mainline", so I have a habit of putting the > underscore when I should not. I see. But going back to the commit message - why would the files be skipped? At some point you shared a warning which gets printed: # Warning: file test_ingress_egress_chaining.sh is not executable that's a better thing to put in the commit message, than talking about downloading. Keep in mind you need to put a space or two before the # otherwise git will think it's a comment.
diff --git a/tools/testing/selftests/net/test_ingress_egress_chaining.sh b/tools/testing/selftests/net/test_ingress_egress_chaining.sh
old mode 100644
new mode 100755
Turn on the execution bit for the shell script file. The test is skipped when downloaded from the linux_mainline source files. Signed-off-by: David Hunter <david.hunter.linux@gmail.com> --- V1 --> V2 - Split the patch into two separate patches (one for each issue) - Included subject prefixes --- tools/testing/selftests/net/test_ingress_egress_chaining.sh | 0 1 file changed, 0 insertions(+), 0 deletions(-) mode change 100644 => 100755 tools/testing/selftests/net/test_ingress_egress_chaining.sh