| Message ID | 20240828030511.443605-3-quic_jingyw@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | remoteproc: qcom: Introduce DSP support for QCS8300 | expand |
On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote: > Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300 > platform. > > Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index ef82835e98a4..368aa9cc0051 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = { > .ssctl_id = 0x14, > }; > > +static const struct adsp_data qcs8300_adsp_resource = { > + .crash_reason_smem = 423, > + .firmware_name = "adsp.mdt", Why this is mdt, not mbn? Sorry, it is again some old driver :( Best regards, Krzysztof
On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote: > Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300 > platform. > > Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> > --- > drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++ > 1 file changed, 55 insertions(+) > > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c > index ef82835e98a4..368aa9cc0051 100644 > --- a/drivers/remoteproc/qcom_q6v5_pas.c > +++ b/drivers/remoteproc/qcom_q6v5_pas.c > @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = { > .ssctl_id = 0x14, > }; > > +static const struct adsp_data qcs8300_adsp_resource = { > + .crash_reason_smem = 423, You just duplicate stuff. This is EXACTLY the same as SA8775p. NAK. Best regards, Krzysztof
On 8/28/2024 3:24 PM, Krzysztof Kozlowski wrote: > On Wed, Aug 28, 2024 at 11:05:11AM +0800, Jingyi Wang wrote: >> Add support for PIL loading on ADSP, CDSP and GPDSP on QCS8300 >> platform. >> >> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com> >> --- >> drivers/remoteproc/qcom_q6v5_pas.c | 55 ++++++++++++++++++++++++++++++ >> 1 file changed, 55 insertions(+) >> >> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c >> index ef82835e98a4..368aa9cc0051 100644 >> --- a/drivers/remoteproc/qcom_q6v5_pas.c >> +++ b/drivers/remoteproc/qcom_q6v5_pas.c >> @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = { >> .ssctl_id = 0x14, >> }; >> >> +static const struct adsp_data qcs8300_adsp_resource = { >> + .crash_reason_smem = 423, > > You just duplicate stuff. This is EXACTLY the same as SA8775p. Agreed with you. Offline checked with Jingyi, she will remove the creation and use sa8775p_adsp_resource directly. Will it be ok to put the second patchset here along with the qcs8300 base dt changes together? > > NAK. > > Best regards, > Krzysztof >
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index ef82835e98a4..368aa9cc0051 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -857,6 +857,58 @@ static const struct adsp_data sdm845_adsp_resource_init = { .ssctl_id = 0x14, }; +static const struct adsp_data qcs8300_adsp_resource = { + .crash_reason_smem = 423, + .firmware_name = "adsp.mdt", + .pas_id = 1, + .minidump_id = 5, + .auto_boot = true, + .proxy_pd_names = (char*[]){ + "lcx", + "lmx", + NULL + }, + .load_state = "adsp", + .ssr_name = "lpass", + .sysmon_name = "adsp", + .ssctl_id = 0x14, +}; + +static const struct adsp_data qcs8300_cdsp_resource = { + .crash_reason_smem = 601, + .firmware_name = "cdsp0.mdt", + .pas_id = 18, + .minidump_id = 7, + .auto_boot = true, + .proxy_pd_names = (char*[]){ + "cx", + "mxc", + "nsp0", + NULL + }, + .load_state = "cdsp", + .ssr_name = "cdsp", + .sysmon_name = "cdsp", + .ssctl_id = 0x17, +}; + +static const struct adsp_data qcs8300_gpdsp_resource = { + .crash_reason_smem = 640, + .firmware_name = "gpdsp0.mdt", + .pas_id = 39, + .minidump_id = 21, + .auto_boot = true, + .proxy_pd_names = (char*[]){ + "cx", + "mxc", + NULL + }, + .load_state = "gpdsp", + .ssr_name = "gpdsp", + .sysmon_name = "gpdsp", + .ssctl_id = 0x21, +}; + static const struct adsp_data sm6350_adsp_resource = { .crash_reason_smem = 423, .firmware_name = "adsp.mdt", @@ -1416,6 +1468,9 @@ static const struct of_device_id adsp_of_match[] = { { .compatible = "qcom,qcs404-adsp-pas", .data = &adsp_resource_init }, { .compatible = "qcom,qcs404-cdsp-pas", .data = &cdsp_resource_init }, { .compatible = "qcom,qcs404-wcss-pas", .data = &wcss_resource_init }, + { .compatible = "qcom,qcs8300-adsp-pas", .data = &qcs8300_adsp_resource}, + { .compatible = "qcom,qcs8300-cdsp-pas", .data = &qcs8300_cdsp_resource}, + { .compatible = "qcom,qcs8300-gpdsp-pas", .data = &qcs8300_gpdsp_resource}, { .compatible = "qcom,sa8775p-adsp-pas", .data = &sa8775p_adsp_resource}, { .compatible = "qcom,sa8775p-cdsp0-pas", .data = &sa8775p_cdsp0_resource}, { .compatible = "qcom,sa8775p-cdsp1-pas", .data = &sa8775p_cdsp1_resource},