diff mbox series

firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION

Message ID 20240828014746.1713728-1-peng.fan@oss.nxp.com (mailing list archive)
State New
Headers show
Series firmware: arm_scmi: imx: add MODULE_LICENSE/DESCRIPTION | expand

Commit Message

Peng Fan (OSS) Aug. 28, 2024, 1:47 a.m. UTC 
From: Peng Fan <peng.fan@nxp.com>

Add missing MODULE_LICENSE and MODULE_DESCRIPTION

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

Hi Sudeep,
 My bad for not build this as module. If you need me fix the previous patchset,
 please let me know.
Thanks,
Peng.

 drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c  | 3 +++
 drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
 2 files changed, 6 insertions(+)

Comments

Peng Fan Aug. 28, 2024, 5:17 a.m. UTC | #1 
> Subject: [PATCH] firmware: arm_scmi: imx: add
> MODULE_LICENSE/DESCRIPTION
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> 
> Hi Sudeep,
>  My bad for not build this as module. If you need me fix the previous
> patchset,  please let me know.
> Thanks,
> Peng.
> 
>  drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c  | 3 +++
> drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> index 0df7ca135c34..ad8734d2aeab 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> @@ -377,3 +377,6 @@ static const struct scmi_protocol
> scmi_imx_bbm = {
>  	.sub_vendor_id = "IMX",
>  };
>  module_scmi_protocol(scmi_imx_bbm);
> +
> +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> MODULE_LICENSE("GPL");
> diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> index 9ee2d204d607..1d339cfa6ecf 100644
> --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> @@ -313,3 +313,6 @@ static const struct scmi_protocol
> scmi_imx_misc = {
>  	.sub_vendor_id = "IMX",
>  };
>  module_scmi_protocol(scmi_imx_misc);
> +
> +MODULE_DESCRIPTION("i.MX SCMI BBM driver");

Just find this Typo. BBM->MISC.

Thanks,
Peng.

> MODULE_LICENSE("GPL");
> --
> 2.37.1
Sudeep Holla Aug. 28, 2024, 9:47 a.m. UTC | #2 
On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote:
> > Subject: [PATCH] firmware: arm_scmi: imx: add
> > MODULE_LICENSE/DESCRIPTION
> >
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > ---
> >
> > Hi Sudeep,
> >  My bad for not build this as module. If you need me fix the previous
> > patchset,  please let me know.
> > Thanks,
> > Peng.
> >
> >  drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c  | 3 +++
> > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > index 0df7ca135c34..ad8734d2aeab 100644
> > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > @@ -377,3 +377,6 @@ static const struct scmi_protocol
> > scmi_imx_bbm = {
> >  	.sub_vendor_id = "IMX",
> >  };
> >  module_scmi_protocol(scmi_imx_bbm);
> > +
> > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> > MODULE_LICENSE("GPL");
> > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > index 9ee2d204d607..1d339cfa6ecf 100644
> > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > @@ -313,3 +313,6 @@ static const struct scmi_protocol
> > scmi_imx_misc = {
> >  	.sub_vendor_id = "IMX",
> >  };
> >  module_scmi_protocol(scmi_imx_misc);
> > +
> > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
>
> Just find this Typo. BBM->MISC.
>

I was about to ask the same. Please take time needed to push out any
patch, no point in rushing and churning unnecessarily like this.

Anyways, I did hit the issue last night and fixed it locally but
didn't push out as it was late for today's next. Please check if
https://git.kernel.org/sudeep.holla/c/for-next/scmi/updates
looks OK.

--
Regards,
Sudeep
Peng Fan Aug. 28, 2024, 12:43 p.m. UTC | #3 
> Subject: Re: [PATCH] firmware: arm_scmi: imx: add
> MODULE_LICENSE/DESCRIPTION
> 
> On Wed, Aug 28, 2024 at 05:17:27AM +0000, Peng Fan wrote:
> > > Subject: [PATCH] firmware: arm_scmi: imx: add
> > > MODULE_LICENSE/DESCRIPTION
> > >
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > Add missing MODULE_LICENSE and MODULE_DESCRIPTION
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > ---
> > >
> > > Hi Sudeep,
> > >  My bad for not build this as module. If you need me fix the
> > > previous patchset,  please let me know.
> > > Thanks,
> > > Peng.
> > >
> > >  drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c  | 3 +++
> > > drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 3 +++
> > >  2 files changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > index 0df7ca135c34..ad8734d2aeab 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
> > > @@ -377,3 +377,6 @@ static const struct scmi_protocol
> scmi_imx_bbm =
> > > {
> > >  	.sub_vendor_id = "IMX",
> > >  };
> > >  module_scmi_protocol(scmi_imx_bbm);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> > > MODULE_LICENSE("GPL");
> > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > index 9ee2d204d607..1d339cfa6ecf 100644
> > > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
> > > @@ -313,3 +313,6 @@ static const struct scmi_protocol
> scmi_imx_misc
> > > = {
> > >  	.sub_vendor_id = "IMX",
> > >  };
> > >  module_scmi_protocol(scmi_imx_misc);
> > > +
> > > +MODULE_DESCRIPTION("i.MX SCMI BBM driver");
> >
> > Just find this Typo. BBM->MISC.
> >
> 
> I was about to ask the same. Please take time needed to push out any
> patch, no point in rushing and churning unnecessarily like this.
> 
> Anyways, I did hit the issue last night and fixed it locally but didn't
> push out as it was late for today's next. Please check if
> https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git/commit/?id=for-next/scmi/updates

Your fix is good. Thanks for helping on this issue. I will take care
next time.

Thanks,
Peng.

> 
> --
> Regards,
> Sudeep
diff mbox series

Patch

diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
index 0df7ca135c34..ad8734d2aeab 100644
--- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
+++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-bbm.c
@@ -377,3 +377,6 @@  static const struct scmi_protocol scmi_imx_bbm = {
 	.sub_vendor_id = "IMX",
 };
 module_scmi_protocol(scmi_imx_bbm);
+
+MODULE_DESCRIPTION("i.MX SCMI BBM driver");
+MODULE_LICENSE("GPL");
diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
index 9ee2d204d607..1d339cfa6ecf 100644
--- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
+++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c
@@ -313,3 +313,6 @@  static const struct scmi_protocol scmi_imx_misc = {
 	.sub_vendor_id = "IMX",
 };
 module_scmi_protocol(scmi_imx_misc);
+
+MODULE_DESCRIPTION("i.MX SCMI BBM driver");
+MODULE_LICENSE("GPL");