| Message ID | 20240828-work-kmem_cache-rcu-v3-1-5460bc1f09f6@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | fs,mm: add kmem_cache_create_rcu() | expand |
Ad subject: "... of create_cache()" ? On 8/28/24 12:56, Christian Brauner wrote: > That argument is unused so remove it. > > Signed-off-by: Christian Brauner <brauner@kernel.org> Reviewed-by: Vlastimil Babka <vbabka@suse.cz> > --- > mm/slab_common.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 40b582a014b8..c8dd7e08c5f6 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -204,8 +204,7 @@ struct kmem_cache *find_mergeable(unsigned int size, unsigned int align, > static struct kmem_cache *create_cache(const char *name, > unsigned int object_size, unsigned int align, > slab_flags_t flags, unsigned int useroffset, > - unsigned int usersize, void (*ctor)(void *), > - struct kmem_cache *root_cache) > + unsigned int usersize, void (*ctor)(void *)) > { > struct kmem_cache *s; > int err; > @@ -334,7 +333,7 @@ kmem_cache_create_usercopy(const char *name, > > s = create_cache(cache_name, size, > calculate_alignment(flags, align, size), > - flags, useroffset, usersize, ctor, NULL); > + flags, useroffset, usersize, ctor); > if (IS_ERR(s)) { > err = PTR_ERR(s); > kfree_const(cache_name); >
On Wed, Aug 28, 2024 at 05:05:11PM GMT, Vlastimil Babka wrote:
> Ad subject: "... of create_cache()" ?
Done. See vfs.file. on vfs/vfs.git.
diff --git a/mm/slab_common.c b/mm/slab_common.c index 40b582a014b8..c8dd7e08c5f6 100644 --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -204,8 +204,7 @@ struct kmem_cache *find_mergeable(unsigned int size, unsigned int align, static struct kmem_cache *create_cache(const char *name, unsigned int object_size, unsigned int align, slab_flags_t flags, unsigned int useroffset, - unsigned int usersize, void (*ctor)(void *), - struct kmem_cache *root_cache) + unsigned int usersize, void (*ctor)(void *)) { struct kmem_cache *s; int err; @@ -334,7 +333,7 @@ kmem_cache_create_usercopy(const char *name, s = create_cache(cache_name, size, calculate_alignment(flags, align, size), - flags, useroffset, usersize, ctor, NULL); + flags, useroffset, usersize, ctor); if (IS_ERR(s)) { err = PTR_ERR(s); kfree_const(cache_name);
That argument is unused so remove it. Signed-off-by: Christian Brauner <brauner@kernel.org> --- mm/slab_common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)