diff mbox series

[v4,3/3] arm64: defconfig: Enable interconnect for SM4450

Message ID 20240813-sm4450_interconnect-v4-3-41a426f0fc49@quicinc.com (mailing list archive)
State Changes Requested
Headers show
Series interconnect: qcom: Add SM4450 interconnect | expand

Commit Message

Tengfei Fan Aug. 13, 2024, 2:47 a.m. UTC
Add the SM4450 interconnect driver as built-in. On SM4450 platform,
support for features such as UFS and USB will be gradually implemented.
These features rely on interconnect, so the internnect functionality
need to be enabled.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Baryshkov Aug. 28, 2024, 8:40 p.m. UTC | #1
On Tue, Aug 13, 2024 at 10:47:55AM GMT, Tengfei Fan wrote:
> Add the SM4450 interconnect driver as built-in. On SM4450 platform,
> support for features such as UFS and USB will be gradually implemented.
> These features rely on interconnect, so the internnect functionality
> need to be enabled.

Please take a look at the git log of the defconfig. Usually commits name
a device which requires the driver rather than just mentioning a
platform. Also if intercoonect driver is only required when USB or UFS
blocks are supported on the platform, please consider enabling it as a
part of the corresponding features enablement.

> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 01dd286ba7ef..593b89e66166 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1624,6 +1624,7 @@ CONFIG_INTERCONNECT_QCOM_SC8180X=y
>  CONFIG_INTERCONNECT_QCOM_SC8280XP=y
>  CONFIG_INTERCONNECT_QCOM_SDM845=y
>  CONFIG_INTERCONNECT_QCOM_SDX75=y
> +CONFIG_INTERCONNECT_QCOM_SM4450=y
>  CONFIG_INTERCONNECT_QCOM_SM6115=y
>  CONFIG_INTERCONNECT_QCOM_SM8150=y
>  CONFIG_INTERCONNECT_QCOM_SM8250=y
> 
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 01dd286ba7ef..593b89e66166 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -1624,6 +1624,7 @@  CONFIG_INTERCONNECT_QCOM_SC8180X=y
 CONFIG_INTERCONNECT_QCOM_SC8280XP=y
 CONFIG_INTERCONNECT_QCOM_SDM845=y
 CONFIG_INTERCONNECT_QCOM_SDX75=y
+CONFIG_INTERCONNECT_QCOM_SM4450=y
 CONFIG_INTERCONNECT_QCOM_SM6115=y
 CONFIG_INTERCONNECT_QCOM_SM8150=y
 CONFIG_INTERCONNECT_QCOM_SM8250=y