[net,v6,0/3] ptp: ocp: fix serial port information export

Message

Vadim Fedorenko Aug. 28, 2024, 6:12 p.m. UTC

Starting v6.8 the serial port subsystem changed the hierarchy of devices
and symlinks are not working anymore. Previous discussion made it clear
that the idea of symlinks for tty devices was wrong by design [1].
This series implements additional attributes to expose the information
and removes symlinks for tty devices.

[1] https://lore.kernel.org/netdev/2024060503-subsonic-pupil-bbee@gregkh/

v5 -> v6:
- split conversion to array to separate patch per Jiri's feedback
- move changelog to cover letter
v4 -> v5:
- remove unused variable in ptp_ocp_tty_show
v3 -> v4:
- re-organize info printing to use ptp_ocp_tty_port_name()
- keep uintptr_t to be consistent with other code
v2 -> v3:
- replace serial ports definitions with array and enum for index
- replace pointer math with direct array access
- nit in documentation spelling
v1 -> v2:
- add Documentation/ABI changes

Vadim Fedorenko (3):
  ptp: ocp: convert serial ports to array
  ptp: ocp: adjust sysfs entries to expose tty information
  docs: ABI: update OCP TimeCard sysfs entries

 Documentation/ABI/testing/sysfs-timecard |  31 +++--
 drivers/ptp/ptp_ocp.c                    | 168 ++++++++++++++---------
 2 files changed, 119 insertions(+), 80 deletions(-)

Comments

Jakub Kicinski Aug. 29, 2024, 2:15 a.m. UTC | #1

On Wed, 28 Aug 2024 11:12:16 -0700 Vadim Fedorenko wrote:
> Starting v6.8 the serial port subsystem changed the hierarchy of devices
> and symlinks are not working anymore. Previous discussion made it clear
> that the idea of symlinks for tty devices was wrong by design [1].
> This series implements additional attributes to expose the information
> and removes symlinks for tty devices.

Doesn't apply now :(

Applying: ptp: ocp: convert serial ports to array
Applying: ptp: ocp: adjust sysfs entries to expose tty information
error: sha1 information is lacking or useless (drivers/ptp/ptp_ocp.c).
error: could not build fake ancestor
Patch failed at 0002 ptp: ocp: adjust sysfs entries to expose tty information
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

Vadim Fedorenko Aug. 29, 2024, 10:24 a.m. UTC | #2

On 29/08/2024 03:15, Jakub Kicinski wrote:
> On Wed, 28 Aug 2024 11:12:16 -0700 Vadim Fedorenko wrote:
>> Starting v6.8 the serial port subsystem changed the hierarchy of devices
>> and symlinks are not working anymore. Previous discussion made it clear
>> that the idea of symlinks for tty devices was wrong by design [1].
>> This series implements additional attributes to expose the information
>> and removes symlinks for tty devices.
> 
> Doesn't apply now :(
> 
> Applying: ptp: ocp: convert serial ports to array
> Applying: ptp: ocp: adjust sysfs entries to expose tty information
> error: sha1 information is lacking or useless (drivers/ptp/ptp_ocp.c).
> error: could not build fake ancestor
> Patch failed at 0002 ptp: ocp: adjust sysfs entries to expose tty information
> hint: Use 'git am --show-current-patch=diff' to see the failed patch
> hint: When you have resolved this problem, run "git am --continue".
> hint: If you prefer to skip this patch, run "git am --skip" instead.
> hint: To restore the original branch and stop patching, run "git am --abort".
> hint: Disable this message with "git config advice.mergeConflict false"

Ah, I found the reason. Will send v7 soon.