diff mbox series

[RESEND,1/3] dt-bindings: apple,aic: Document A7-A11 compatibles

Message ID 20240829110436.46052-2-towinchenmi@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series Add AIC support for A7-A11 SoCs | expand

Commit Message

Nick Chan Aug. 29, 2024, 11:02 a.m. UTC
Document the compatibles for Apple A7-A11 SoCs.

There are three feature levels:
- A7-A10: No fast IPI
- A11: fast IPI, global only
- M1: fast IPI with local and global support

Signed-off-by: Nick Chan <towinchenmi@gmail.com>
---
 .../bindings/interrupt-controller/apple,aic.yaml          | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Aug. 29, 2024, 11:46 a.m. UTC | #1
On 29/08/2024 13:02, Nick Chan wrote:
> Document the compatibles for Apple A7-A11 SoCs.
> 
> There are three feature levels:
> - A7-A10: No fast IPI
> - A11: fast IPI, global only
> - M1: fast IPI with local and global support
> 
> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
> ---

Please do not resend different patch. Or rather explain - is this the
same? Looks different, so RESEND is not appropriate.

Follow submitting patches in this regard, you need v2. Just use b4 for
this process.

Best regards,
Krzysztof
Nick Chan Aug. 29, 2024, noon UTC | #2
On 29/8/2024 19:46, Krzysztof Kozlowski wrote:
> Please do not resend different patch. Or rather explain - is this the
> same? Looks different, so RESEND is not appropriate.
> 
> Follow submitting patches in this regard, you need v2. Just use b4 for
> this process.
Right. Since versions of patch series should not be sent too frequently,
I suppose a v2 should be sent next week. (Sorry - not super familiar
with the process)

>
> Best regards,

Nick Chan
Krzysztof Kozlowski Aug. 29, 2024, 12:37 p.m. UTC | #3
On 29/08/2024 14:00, Nick Chan wrote:
> 
> 
> On 29/8/2024 19:46, Krzysztof Kozlowski wrote:
>> Please do not resend different patch. Or rather explain - is this the
>> same? Looks different, so RESEND is not appropriate.
>>
>> Follow submitting patches in this regard, you need v2. Just use b4 for
>> this process.
> Right. Since versions of patch series should not be sent too frequently,
> I suppose a v2 should be sent next week. (Sorry - not super familiar
> with the process)

Once per day, so other reviewers will have time to respond. I also
responded to your earlier posting, before I noticed the resend, so
please improve the commit msg as I suggested.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
index 698588e9aa86..2e38b585a722 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
+++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml
@@ -37,7 +37,13 @@  allOf:
 properties:
   compatible:
     items:
-      - const: apple,t8103-aic
+      - enum:
+          - apple,s5l8960x-aic
+          - apple,s8000-aic
+          - apple,t7000-aic
+          - apple,t8010-aic
+          - apple,t8015-aic
+          - apple,t8103-aic
       - const: apple,aic
 
   interrupt-controller: true