diff mbox series

ARM: dts: stm32: include st,stm32mp13-regulator.h in stm32mp131.dtsi

Message ID 20240813094856.2002113-1-linux@rasmusvillemoes.dk (mailing list archive)
State New, archived
Headers show
Series ARM: dts: stm32: include st,stm32mp13-regulator.h in stm32mp131.dtsi | expand

Commit Message

Rasmus Villemoes Aug. 13, 2024, 9:48 a.m. UTC 
From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>

The file stm32mp131.dtsi uses symbolic constants such as
VOLTD_SCMI_REG11, VOLTD_SCMI_REG18 etc., but does not include the
header where they are defined. So when adding a new .dts file that
includes stm32mp131.dtsi, the build breaks unless the .dts itself
includes st,stm32mp13-regulator.h.

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---

OTOH, it seems that (if this is applied) stm32mp135f-dhcor-dhsbc.dts and
stm32mp13xx-dhcor-som.dtsi could drop their #includes as they do not
use any of the VOLTD_SCMI_* constants except through stm32mp131.dtsi.

 arch/arm/boot/dts/st/stm32mp131.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Alexandre TORGUE Aug. 30, 2024, 4:10 p.m. UTC | #1 
Hi Rasmus

On 8/13/24 11:48, Rasmus Villemoes wrote:
> From: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> 
> The file stm32mp131.dtsi uses symbolic constants such as
> VOLTD_SCMI_REG11, VOLTD_SCMI_REG18 etc., but does not include the
> header where they are defined. So when adding a new .dts file that
> includes stm32mp131.dtsi, the build breaks unless the .dts itself
> includes st,stm32mp13-regulator.h.
> 
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> 
> OTOH, it seems that (if this is applied) stm32mp135f-dhcor-dhsbc.dts and
> stm32mp13xx-dhcor-som.dtsi could drop their #includes as they do not
> use any of the VOLTD_SCMI_* constants except through stm32mp131.dtsi.

Thanks for this fix. I think it would be nice to add to this series 
boards updates by removing "#include 
<dt-bindings/regulator/st,stm32mp13-regulator.h>".

Thanks in advance
Alex

> 
>   arch/arm/boot/dts/st/stm32mp131.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
> index e1a764d269d2..490d38dc8d54 100644
> --- a/arch/arm/boot/dts/st/stm32mp131.dtsi
> +++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
> @@ -5,6 +5,7 @@
>    */
>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>   #include <dt-bindings/clock/stm32mp13-clks.h>
> +#include <dt-bindings/regulator/st,stm32mp13-regulator.h>
>   #include <dt-bindings/reset/stm32mp13-resets.h>
>   
>   / {
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/st/stm32mp131.dtsi b/arch/arm/boot/dts/st/stm32mp131.dtsi
index e1a764d269d2..490d38dc8d54 100644
--- a/arch/arm/boot/dts/st/stm32mp131.dtsi
+++ b/arch/arm/boot/dts/st/stm32mp131.dtsi
@@ -5,6 +5,7 @@ 
  */
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/clock/stm32mp13-clks.h>
+#include <dt-bindings/regulator/st,stm32mp13-regulator.h>
 #include <dt-bindings/reset/stm32mp13-resets.h>
 
 / {