| Message ID | 20240829021253.3066-1-shenlichuan@vivo.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 74ce94ac38a6eac2ffc235739294f24964fd0a86 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2] sfc: Convert to use ERR_CAST() | expand |
On Thu, Aug 29, 2024 at 10:12:53AM +0800, Shen Lichuan wrote: > As opposed to open-code, using the ERR_CAST macro clearly indicates that > this is a pointer to an error value and a type conversion was performed. > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Reviewed-by: Martin Habets <habetsm.xilinx@gmail.com> > --- > v1 -> v2: Removed the superfluous comment. > > drivers/net/ethernet/sfc/tc_counters.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c > index c44088424323..a421b0123506 100644 > --- a/drivers/net/ethernet/sfc/tc_counters.c > +++ b/drivers/net/ethernet/sfc/tc_counters.c > @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index( > &ctr->linkage, > efx_tc_counter_id_ht_params); > kfree(ctr); > - return (void *)cnt; /* it's an ERR_PTR */ > + return ERR_CAST(cnt); > } > ctr->cnt = cnt; > refcount_set(&ctr->ref, 1); > -- > 2.17.1 >
On 29/08/2024 03:12, Shen Lichuan wrote: > As opposed to open-code, using the ERR_CAST macro clearly indicates that > this is a pointer to an error value and a type conversion was performed. > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > --- Reviewed-by: Edward Cree <ecree.xilinx@gmail.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 29 Aug 2024 10:12:53 +0800 you wrote: > As opposed to open-code, using the ERR_CAST macro clearly indicates that > this is a pointer to an error value and a type conversion was performed. > > Signed-off-by: Shen Lichuan <shenlichuan@vivo.com> > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > --- > v1 -> v2: Removed the superfluous comment. > > [...] Here is the summary with links: - [v2] sfc: Convert to use ERR_CAST() https://git.kernel.org/netdev/net-next/c/74ce94ac38a6 You are awesome, thank you!
diff --git a/drivers/net/ethernet/sfc/tc_counters.c b/drivers/net/ethernet/sfc/tc_counters.c index c44088424323..a421b0123506 100644 --- a/drivers/net/ethernet/sfc/tc_counters.c +++ b/drivers/net/ethernet/sfc/tc_counters.c @@ -249,7 +249,7 @@ struct efx_tc_counter_index *efx_tc_flower_get_counter_index( &ctr->linkage, efx_tc_counter_id_ht_params); kfree(ctr); - return (void *)cnt; /* it's an ERR_PTR */ + return ERR_CAST(cnt); } ctr->cnt = cnt; refcount_set(&ctr->ref, 1);