diff mbox series

[1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible

Message ID 20240902075220.27971-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State In Next, archived
Headers show
Series [1/2] arm64: dts: imx8mm-var-som: drop unused top-level compatible | expand

Commit Message

Krzysztof Kozlowski Sept. 2, 2024, 7:52 a.m. UTC
The Variscite VAR-SOM-MX8MM System-on-Module cannot be used alone
without motherboard, so drop the top-level compatible field to avoid any
false impression that such usage is possible.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Peng Fan Sept. 2, 2024, 10:13 a.m. UTC | #1
> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
> level compatible
> 
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the top-level compatible field to
> avoid any false impression that such usage is possible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> index d7830df5b6f9..cdfacbc35db5 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
> @@ -8,7 +8,6 @@
> 
>  / {
>  	model = "Variscite VAR-SOM-MX8MM module";
> -	compatible = "variscite,var-som-mx8mm", "fsl,imx8mm";
> 
>  	chosen {
>  		stdout-path = &uart4;
> --
> 2.43.0
> 

Should the " variscite,var-som-mx8mm " also removed from
imx8mm-var-som-symphony.dts?

Regards,
Peng.
Krzysztof Kozlowski Sept. 2, 2024, 10:19 a.m. UTC | #2
On 02/09/2024 12:13, Peng Fan wrote:
>> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
>> level compatible
>>
>> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
>> alone without motherboard, so drop the top-level compatible field to
>> avoid any false impression that such usage is possible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> index d7830df5b6f9..cdfacbc35db5 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
>> @@ -8,7 +8,6 @@
>>
>>  / {
>>  	model = "Variscite VAR-SOM-MX8MM module";
>> -	compatible = "variscite,var-som-mx8mm", "fsl,imx8mm";
>>
>>  	chosen {
>>  		stdout-path = &uart4;
>> --
>> 2.43.0
>>
> 
> Should the " variscite,var-som-mx8mm " also removed from
> imx8mm-var-som-symphony.dts?

No, why?

Best regards,
Krzysztof
Peng Fan Sept. 2, 2024, 12:27 p.m. UTC | #3
> Subject: [PATCH 1/2] arm64: dts: imx8mm-var-som: drop unused top-
> level compatible
> 
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used
> alone without motherboard, so drop the top-level compatible field to
> avoid any false impression that such usage is possible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
I got a mistake in my previous comment, so

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Thanks,
Peng.
Shawn Guo Sept. 3, 2024, 6:53 a.m. UTC | #4
On Mon, Sep 02, 2024 at 09:52:19AM +0200, Krzysztof Kozlowski wrote:
> The Variscite VAR-SOM-MX8MM System-on-Module cannot be used alone
> without motherboard, so drop the top-level compatible field to avoid any
> false impression that such usage is possible.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Applied both, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
index d7830df5b6f9..cdfacbc35db5 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
@@ -8,7 +8,6 @@ 
 
 / {
 	model = "Variscite VAR-SOM-MX8MM module";
-	compatible = "variscite,var-som-mx8mm", "fsl,imx8mm";
 
 	chosen {
 		stdout-path = &uart4;