[v3,0/2] iomap: flush dirty cache over unwritten mappings on zero range

Message

Brian Foster Aug. 30, 2024, 2:56 p.m. UTC

Hi all,

Here's v3 of the iomap zero range flush fixes. No real changes here
other than comment updates to better explain the flush and stale logic.
The latest version of corresponding test support is posted here [1].
Thoughts, reviews, flames appreciated.

v3:
- Rework comment(s) in patch 2 to explain marking the mapping stale.
- Added R-b tags.
v2: https://lore.kernel.org/linux-fsdevel/[e-mail]/
- Update comment in patch 2 to explain hole case.
v1: https://lore.kernel.org/linux-fsdevel/[e-mail]/
- Alternative approach, flush instead of revalidate.
rfc: https://lore.kernel.org/linux-fsdevel/[e-mail]/

Brian Foster (2):
  iomap: fix handling of dirty folios over unwritten extents
  iomap: make zero range flush conditional on unwritten mappings

 fs/iomap/buffered-io.c | 63 +++++++++++++++++++++++++++++++++++++++---
 fs/xfs/xfs_iops.c      | 10 -------
 2 files changed, 59 insertions(+), 14 deletions(-)

Comments

Christian Brauner Sept. 3, 2024, 7:59 a.m. UTC | #1

On Fri, 30 Aug 2024 10:56:32 -0400, Brian Foster wrote:
> Here's v3 of the iomap zero range flush fixes. No real changes here
> other than comment updates to better explain the flush and stale logic.
> The latest version of corresponding test support is posted here [1].
> Thoughts, reviews, flames appreciated.
> 
> v3:
> - Rework comment(s) in patch 2 to explain marking the mapping stale.
> - Added R-b tags.
> v2: https://lore.kernel.org/linux-fsdevel/[e-mail]/
> - Update comment in patch 2 to explain hole case.
> v1: https://lore.kernel.org/linux-fsdevel/[e-mail]/
> - Alternative approach, flush instead of revalidate.
> rfc: https://lore.kernel.org/linux-fsdevel/[e-mail]/
> 
> [...]

Applied to the vfs.blocksize branch of the vfs/vfs.git tree.
Patches in the vfs.blocksize branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.blocksize

[1/2] iomap: fix handling of dirty folios over unwritten extents
      https://git.kernel.org/vfs/vfs/c/e19d398f4eb8
[2/2] iomap: make zero range flush conditional on unwritten mappings
      https://git.kernel.org/vfs/vfs/c/2dbdb9dbad46