| Message ID | 20240903-c3isp-v1-3-8af0edcc13c8@amlogic.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Amlogic C3 ISP support | expand |
On 03/09/2024 08:57, Keke Li via B4 Relay wrote: > From: Keke Li <keke.li@amlogic.com> > > c3-mipi-adapter is used to organize mipi data and > send raw data to ISP module. > > Signed-off-by: Keke Li <keke.li@amlogic.com> > --- > .../bindings/media/amlogic,c3-mipi-adapter.yaml | 114 +++++++++++++++++++++ > 1 file changed, 114 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml > new file mode 100644 > index 000000000000..e1873fe829c7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml > @@ -0,0 +1,114 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Amlogic C3 MIPI adapter receiver > + > +maintainers: > + - Keke Li <keke.li@amlogic.com> > + > +description: |- Same comment. > + MIPI adapter is used to convert the MIPI CSI-2 data > + into an ISP supported data format. > + > +properties: > + compatible: > + enum: > + - amlogic,c3-mipi-adapter > + > + reg: > + minItems: 3 Same comment. > + maxItems: 3 > + > + reg-names: > + items: > + - const: adap_top > + - const: adap_fd > + - const: adap_rd Same comment. > + > + power-domains: > + maxItems: 1 > + > + clocks: > + minItems: 2 Same comment. > + > + clock-names: > + items: > + - const: vapb > + - const: adap > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: input port node. > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: output port node. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - reg-names > + - power-domains > + - clocks > + - clock-names > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h> > + #include <dt-bindings/power/amlogic,c3-pwrc.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + adap: adap@ff010000 { > + compatible = "amlogic,c3-mipi-adapter"; > + Same comments. Best regards, Krzysztof
Hi Krzysztof, Thanks for your reply. On 2024/9/3 22:11, Krzysztof Kozlowski wrote: > [You don't often get email from krzk@kernel.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > [ EXTERNAL EMAIL ] > > On 03/09/2024 08:57, Keke Li via B4 Relay wrote: >> From: Keke Li <keke.li@amlogic.com> >> >> c3-mipi-adapter is used to organize mipi data and >> send raw data to ISP module. >> >> Signed-off-by: Keke Li <keke.li@amlogic.com> >> --- >> .../bindings/media/amlogic,c3-mipi-adapter.yaml | 114 +++++++++++++++++++++ >> 1 file changed, 114 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml >> new file mode 100644 >> index 000000000000..e1873fe829c7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml >> @@ -0,0 +1,114 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Amlogic C3 MIPI adapter receiver >> + >> +maintainers: >> + - Keke Li <keke.li@amlogic.com> >> + >> +description: |- > Same comment. OK, get it. >> + MIPI adapter is used to convert the MIPI CSI-2 data >> + into an ISP supported data format. >> + >> +properties: >> + compatible: >> + enum: >> + - amlogic,c3-mipi-adapter >> + >> + reg: >> + minItems: 3 > Same comment. OK, get it. >> + maxItems: 3 >> + >> + reg-names: >> + items: >> + - const: adap_top >> + - const: adap_fd >> + - const: adap_rd > Same comment. OK, get it. >> + >> + power-domains: >> + maxItems: 1 >> + >> + clocks: >> + minItems: 2 > Same comment. OK, get it. >> + >> + clock-names: >> + items: >> + - const: vapb >> + - const: adap >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: input port node. >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/properties/port >> + description: output port node. >> + >> + required: >> + - port@0 >> + - port@1 >> + >> +required: >> + - compatible >> + - reg >> + - reg-names >> + - power-domains >> + - clocks >> + - clock-names >> + - ports >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h> >> + #include <dt-bindings/power/amlogic,c3-pwrc.h> >> + >> + soc { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + >> + adap: adap@ff010000 { >> + compatible = "amlogic,c3-mipi-adapter"; >> + > Same comments. OK, get it. > > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml new file mode 100644 index 000000000000..e1873fe829c7 --- /dev/null +++ b/Documentation/devicetree/bindings/media/amlogic,c3-mipi-adapter.yaml @@ -0,0 +1,114 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/amlogic,c3-mipi-adapter.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Amlogic C3 MIPI adapter receiver + +maintainers: + - Keke Li <keke.li@amlogic.com> + +description: |- + MIPI adapter is used to convert the MIPI CSI-2 data + into an ISP supported data format. + +properties: + compatible: + enum: + - amlogic,c3-mipi-adapter + + reg: + minItems: 3 + maxItems: 3 + + reg-names: + items: + - const: adap_top + - const: adap_fd + - const: adap_rd + + power-domains: + maxItems: 1 + + clocks: + minItems: 2 + + clock-names: + items: + - const: vapb + - const: adap + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/properties/port + description: input port node. + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: output port node. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - reg-names + - power-domains + - clocks + - clock-names + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/amlogic,c3-peripherals-clkc.h> + #include <dt-bindings/power/amlogic,c3-pwrc.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + adap: adap@ff010000 { + compatible = "amlogic,c3-mipi-adapter"; + + reg = <0x0 0xff010000 0x0 0x100>, + <0x0 0xff01b000 0x0 0x100>, + <0x0 0xff01d000 0x0 0x200>; + + reg-names = "adap_top", "adap_fd", "adap_rd"; + + power-domains = <&pwrc PWRC_C3_ISP_TOP_ID>; + + clocks = <&clkc_periphs CLKID_VAPB>, + <&clkc_periphs CLKID_ISP0>; + + clock-names = "vapb", "adap"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + c3_adap_in: endpoint { + remote-endpoint = <&c3_mipi_csi_out>; + }; + }; + + port@1 { + reg = <1>; + c3_adap_out: endpoint { + remote-endpoint = <&c3_isp_in>; + }; + }; + }; + }; + }; +...