| Message ID | 20240903131503.961178-1-liaochen4@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next] serial: 8250_aspeed_vuart: Enable module autoloading | expand |
Hello, On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote: > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > on the alias from of_device_id table. > > Signed-off-by: Liao Chen <liaochen4@huawei.com> > --- > drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c > index 53d8eee9b1c8..25c201cfb91e 100644 > --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c > +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c > @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = { > { .compatible = "aspeed,ast2500-vuart" }, > { }, > }; > +MODULE_DEVICE_TABLE(of, aspeed_vuart_table); I wonder if you found this entry missing by code review, or if you have a machine with that UART and so you actually benefit. Otherwise looks right to me. Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> Best regards Uwe
On Tue, Sep 03, 2024 at 05:49:54PM +0200, Uwe Kleine-König wrote: > On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote: ... > I wonder if you found this entry missing by code review, or if you have > a machine with that UART and so you actually benefit. Using arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts in QEMU I never experienced an issue. Seems due to defconfig having it =y. (used arch/arm/configs/aspeed_g5_defconfig) > Otherwise looks right to me. > > Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
On 2024/9/3 23:49, Uwe Kleine-König wrote: > Hello, > > On Tue, Sep 03, 2024 at 01:15:03PM +0000, Liao Chen wrote: >> Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based >> on the alias from of_device_id table. >> >> Signed-off-by: Liao Chen <liaochen4@huawei.com> >> --- >> drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c >> index 53d8eee9b1c8..25c201cfb91e 100644 >> --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c >> +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c >> @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = { >> { .compatible = "aspeed,ast2500-vuart" }, >> { }, >> }; >> +MODULE_DEVICE_TABLE(of, aspeed_vuart_table); > > I wonder if you found this entry missing by code review, or if you have > a machine with that UART and so you actually benefit. I found it from code review. Since this device could be compiled as a module, I think it is better to add this entry. Thanks, Chen > > Otherwise looks right to me. > > Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> > > Best regards > Uwe
On Tue, 2024-09-03 at 13:15 +0000, Liao Chen wrote: > Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based > on the alias from of_device_id table. > > Signed-off-by: Liao Chen <liaochen4@huawei.com> Acked-by: Andrew Jeffery <andrew@codeconstruct.com.au>
diff --git a/drivers/tty/serial/8250/8250_aspeed_vuart.c b/drivers/tty/serial/8250/8250_aspeed_vuart.c index 53d8eee9b1c8..25c201cfb91e 100644 --- a/drivers/tty/serial/8250/8250_aspeed_vuart.c +++ b/drivers/tty/serial/8250/8250_aspeed_vuart.c @@ -561,6 +561,7 @@ static const struct of_device_id aspeed_vuart_table[] = { { .compatible = "aspeed,ast2500-vuart" }, { }, }; +MODULE_DEVICE_TABLE(of, aspeed_vuart_table); static struct platform_driver aspeed_vuart_driver = { .driver = {
Add MODULE_DEVICE_TABLE(), so modules could be properly autoloaded based on the alias from of_device_id table. Signed-off-by: Liao Chen <liaochen4@huawei.com> --- drivers/tty/serial/8250/8250_aspeed_vuart.c | 1 + 1 file changed, 1 insertion(+)