| Message ID | 1725350397-19527-2-git-send-email-hongxing.zhu@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Add one clock gate for i.MX95 HSIO block | expand |
On 03/09/2024 09:59, Richard Zhu wrote: > Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> Best regards, Krzysztof
Hi Richard, On Tue, Sep 3, 2024 at 5:21 AM Richard Zhu <hongxing.zhu@nxp.com> wrote: > > Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95. > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > --- > Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > index 2dffc02dcd8b..638241f6749f 100644 > --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > @@ -17,6 +17,7 @@ properties: > - nxp,imx95-display-csr > - nxp,imx95-camera-csr > - nxp,imx95-vpu-csr > + - nxp,imx95-hsio-blk-ctl Please keep the entries in alphabetical order.
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2024年9月3日 21:00 > To: Hongxing Zhu <hongxing.zhu@nxp.com>; abelvesa@kernel.org; Peng Fan > <peng.fan@nxp.com>; mturquette@baylibre.com; sboyd@kernel.org; > shawnguo@kernel.org; s.hauer@pengutronix.de; festevam@gmail.com > Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > linux-clk@vger.kernel.org; imx@lists.linux.dev; kernel@pengutronix.de > Subject: Re: [PATCH v1 1/2] dt-bindings: clock: nxp,imx95-blk-ctl: Add > compatible string for i.MX95 HSIO BLK CTRL > > On 03/09/2024 09:59, Richard Zhu wrote: > > Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people and > lists to CC. It might happen, that command when run on an older kernel, gives > you outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so > fix your workflow. Tools might also fail if you work on some ancient tree (don't, > instead use mainline) or work on fork of kernel (don't, instead use mainline). > Just use b4 and everything should be fine, although remember about `b4 prep > --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be tested by > automated tooling. Performing review on untested code might be a waste of > time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> Thanks for reminder. It's my fault missing some entries. Would include all entries later. Best Regards Richard Zhu > > Best regards, > Krzysztof
> -----Original Message----- > From: Fabio Estevam <festevam@gmail.com> > Sent: 2024年9月3日 21:02 > To: Hongxing Zhu <hongxing.zhu@nxp.com> > Cc: abelvesa@kernel.org; Peng Fan <peng.fan@nxp.com>; > mturquette@baylibre.com; sboyd@kernel.org; shawnguo@kernel.org; > s.hauer@pengutronix.de; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-clk@vger.kernel.org; > imx@lists.linux.dev; kernel@pengutronix.de > Subject: Re: [PATCH v1 1/2] dt-bindings: clock: nxp,imx95-blk-ctl: Add > compatible string for i.MX95 HSIO BLK CTRL > > Hi Richard, > > On Tue, Sep 3, 2024 at 5:21 AM Richard Zhu <hongxing.zhu@nxp.com> wrote: > > > > Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95. > > > > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> > > --- > > Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git > a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > > index 2dffc02dcd8b..638241f6749f 100644 > > --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > > +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml > > @@ -17,6 +17,7 @@ properties: > > - nxp,imx95-display-csr > > - nxp,imx95-camera-csr > > - nxp,imx95-vpu-csr > > + - nxp,imx95-hsio-blk-ctl > > Please keep the entries in alphabetical order. Thanks for your comments. I follow the time-sequence to add the changes before. In current compatible items, the alphabetical order is already messed-up. How do you think about the following one? --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml @@ -16,6 +16,7 @@ properties: - nxp,imx95-lvds-csr - nxp,imx95-display-csr - nxp,imx95-camera-csr + - nxp,imx95-hsio-blk-ctl - nxp,imx95-vpu-csr - const: syscon Best Regards Richard Zhu
diff --git a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml index 2dffc02dcd8b..638241f6749f 100644 --- a/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml +++ b/Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml @@ -17,6 +17,7 @@ properties: - nxp,imx95-display-csr - nxp,imx95-camera-csr - nxp,imx95-vpu-csr + - nxp,imx95-hsio-blk-ctl - const: syscon reg:
Add compatible string "nxp,imx95-hsio-blk-ctl" for iMX95. Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com> --- Documentation/devicetree/bindings/clock/nxp,imx95-blk-ctl.yaml | 1 + 1 file changed, 1 insertion(+)