diff mbox series

[05/19] phy: qcom-qmp-ufs: Add support for QCS8300

Message ID 20240904-qcs8300_initial_dtsi-v1-5-d0ea9afdc007@quicinc.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series Add initial support for QCS8300 | expand

Commit Message

Jingyi Wang Sept. 4, 2024, 8:33 a.m. UTC
From: Xin Liu <quic_liuxin@quicinc.com>

Add QMP PHY support for QCS8300 which is compatible with SA8775P.

Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
---
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Sept. 4, 2024, 9:36 a.m. UTC | #1
On 04/09/2024 10:33, Jingyi Wang wrote:
> From: Xin Liu <quic_liuxin@quicinc.com>
> 
> Add QMP PHY support for QCS8300 which is compatible with SA8775P.
> 
> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> index d964bdfe8700..8bad68400736 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
> @@ -2010,6 +2010,9 @@ static const struct of_device_id qmp_ufs_of_match_table[] = {
>  	}, {
>  		.compatible = "qcom,msm8998-qmp-ufs-phy",
>  		.data = &sdm845_ufsphy_cfg,
> +	}, {
> +		.compatible = "qcom,qcs8300-qmp-ufs-phy",
> +		.data = &sa8775p_ufsphy_cfg,

Is compatible? Then this is redundant. Drop.

Best regards,
Krzysztof
Jingyi Wang Sept. 5, 2024, 4:33 a.m. UTC | #2
On 9/4/2024 5:36 PM, Krzysztof Kozlowski wrote:
> On 04/09/2024 10:33, Jingyi Wang wrote:
>> From: Xin Liu <quic_liuxin@quicinc.com>
>>
>> Add QMP PHY support for QCS8300 which is compatible with SA8775P.
>>
>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com>
>> Signed-off-by: Jingyi Wang <quic_jingyw@quicinc.com>
>> ---
>>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> index d964bdfe8700..8bad68400736 100644
>> --- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
>> @@ -2010,6 +2010,9 @@ static const struct of_device_id qmp_ufs_of_match_table[] = {
>>  	}, {
>>  		.compatible = "qcom,msm8998-qmp-ufs-phy",
>>  		.data = &sdm845_ufsphy_cfg,
>> +	}, {
>> +		.compatible = "qcom,qcs8300-qmp-ufs-phy",
>> +		.data = &sa8775p_ufsphy_cfg,
> 
> Is compatible? Then this is redundant. Drop.
> 
> Best regards,
> Krzysztof
> 
Will drop that.

Thanks,
Jingyi
diff mbox series

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index d964bdfe8700..8bad68400736 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -2010,6 +2010,9 @@  static const struct of_device_id qmp_ufs_of_match_table[] = {
 	}, {
 		.compatible = "qcom,msm8998-qmp-ufs-phy",
 		.data = &sdm845_ufsphy_cfg,
+	}, {
+		.compatible = "qcom,qcs8300-qmp-ufs-phy",
+		.data = &sa8775p_ufsphy_cfg,
 	}, {
 		.compatible = "qcom,sa8775p-qmp-ufs-phy",
 		.data = &sa8775p_ufsphy_cfg,