| Message ID | 20240904094218.1925386-4-mkl@pengutronix.de (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,01/20] dt-bindings: can: rockchip_canfd: add rockchip CAN-FD controller | expand |
On 04/09/2024 11:38, Marc Kleine-Budde wrote: > From: David Jander <david@protonic.nl> > > This patch adds support for the CAN0 and CAN1 interfaces to the board. > > Signed-off-by: David Jander <david@protonic.nl> > Tested-by: Alibek Omarov <a1ba.omarov@gmail.com> > Link: https://patch.msgid.link/20240904-rockchip-canfd-v5-3-8ae22bcb27cc@pengutronix.de > [mkl: fixed order of phandles] > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > --- > arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts | 14 ++++++++++++++ DTS patches should never be taken via net/can or or any other driver subsystem. DTS is independent hardware description. Embedding it here suggests there is dependency thus ABI break. Please drop all DTS patches and never apply them via net. Best regards, Krzysztof
On 04.09.2024 13:51:52, Krzysztof Kozlowski wrote: > On 04/09/2024 11:38, Marc Kleine-Budde wrote: > > From: David Jander <david@protonic.nl> > > > > This patch adds support for the CAN0 and CAN1 interfaces to the board. > > > > Signed-off-by: David Jander <david@protonic.nl> > > Tested-by: Alibek Omarov <a1ba.omarov@gmail.com> > > Link: https://patch.msgid.link/20240904-rockchip-canfd-v5-3-8ae22bcb27cc@pengutronix.de > > [mkl: fixed order of phandles] > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> > > Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de> > > --- > > arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts | 14 ++++++++++++++ > > DTS patches should never be taken via net/can or or any other driver > subsystem. Ok. > DTS is independent hardware description. Embedding it here suggests > there is dependency thus ABI break. It might suggest, but it isn't. > Please drop all DTS patches and never apply them via net. Ok, will send an updated PR to net-next and an independent PR to upstream the DTS changes. regards Marc
diff --git a/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts b/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts index c2dfffc638d1..c491dc4d4947 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-mecsbc.dts @@ -89,6 +89,20 @@ vdd_npu: regulator-vdd-npu { }; }; +&can0 { + compatible = "rockchip,rk3568v3-canfd", "rockchip,rk3568v2-canfd"; + pinctrl-names = "default"; + pinctrl-0 = <&can0m0_pins>; + status = "okay"; +}; + +&can1 { + compatible = "rockchip,rk3568v3-canfd", "rockchip,rk3568v2-canfd"; + pinctrl-names = "default"; + pinctrl-0 = <&can1m1_pins>; + status = "okay"; +}; + &combphy0 { status = "okay"; };