diff mbox series

[v2,4/8] ARM: dts: rockchip: Add watchdog node for RV1126

Message ID 20240903105245.715899-5-karthikeyan@linumiz.com (mailing list archive)
State New
Headers show
Series Add support Relfor Saib board which is based on Rockchip RV1109 SoC | expand

Commit Message

karthikeyan Sept. 3, 2024, 10:52 a.m. UTC
Add watchdog node for Rockchip RV1126

Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
---

Notes:
    v2:
    - No change

 arch/arm/boot/dts/rockchip/rv1126.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Heiko Stuebner Sept. 4, 2024, 9:11 a.m. UTC | #1
Am Dienstag, 3. September 2024, 12:52:41 CEST schrieb Karthikeyan Krishnasamy:
> Add watchdog node for Rockchip RV1126
> 
> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>

this needs a separate patch for adding a watchdog compatible to
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml#n33

see for example
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dcd615ee6fd3651ab0357364c4cf65b1148a40be

Thanks
Heiko

> ---
> 
> Notes:
>     v2:
>     - No change
> 
>  arch/arm/boot/dts/rockchip/rv1126.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
> index abf442804d27..283985608428 100644
> --- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
> +++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
> @@ -544,6 +544,14 @@ timer0: timer@ff660000 {
>  		clock-names = "pclk", "timer";
>  	};
>  
> +	wdt: watchdog@ff680000 {
> +		compatible = "snps,dw-wdt";
> +		reg = <0xff680000 0x100>;
> +		clocks = <&cru PCLK_WDT>;
> +		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
> +		status = "disabled";
> +	};
> +
>  	i2s0: i2s@ff800000 {
>  		compatible = "rockchip,rv1126-i2s-tdm";
>  		reg = <0xff800000 0x1000>;
>
karthikeyan Sept. 4, 2024, 2:21 p.m. UTC | #2
On 9/4/24 14:41, Heiko Stübner wrote:
> Am Dienstag, 3. September 2024, 12:52:41 CEST schrieb Karthikeyan Krishnasamy:
>> Add watchdog node for Rockchip RV1126
>>
>> Signed-off-by: Karthikeyan Krishnasamy <karthikeyan@linumiz.com>
> 
> this needs a separate patch for adding a watchdog compatible to
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/watchdog/snps,dw-wdt.yaml#n33
> 
> see for example
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dcd615ee6fd3651ab0357364c4cf65b1148a40be
> 
> Thanks
> Heiko
> 
Additional patch for compatible string, Got it. I will added in the next 
version. Thanks.
>> ---
>>
>> Notes:
>>      v2:
>>      - No change
>>
>>   arch/arm/boot/dts/rockchip/rv1126.dtsi | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> index abf442804d27..283985608428 100644
>> --- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> +++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
>> @@ -544,6 +544,14 @@ timer0: timer@ff660000 {
>>   		clock-names = "pclk", "timer";
>>   	};
>>   
>> +	wdt: watchdog@ff680000 {
>> +		compatible = "snps,dw-wdt";
>> +		reg = <0xff680000 0x100>;
>> +		clocks = <&cru PCLK_WDT>;
>> +		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>> +		status = "disabled";
>> +	};
>> +
>>   	i2s0: i2s@ff800000 {
>>   		compatible = "rockchip,rv1126-i2s-tdm";
>>   		reg = <0xff800000 0x1000>;
>>
> 
> 
> 
> 

Best Regards,
Karthikeyan
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/rockchip/rv1126.dtsi b/arch/arm/boot/dts/rockchip/rv1126.dtsi
index abf442804d27..283985608428 100644
--- a/arch/arm/boot/dts/rockchip/rv1126.dtsi
+++ b/arch/arm/boot/dts/rockchip/rv1126.dtsi
@@ -544,6 +544,14 @@  timer0: timer@ff660000 {
 		clock-names = "pclk", "timer";
 	};
 
+	wdt: watchdog@ff680000 {
+		compatible = "snps,dw-wdt";
+		reg = <0xff680000 0x100>;
+		clocks = <&cru PCLK_WDT>;
+		interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+		status = "disabled";
+	};
+
 	i2s0: i2s@ff800000 {
 		compatible = "rockchip,rv1126-i2s-tdm";
 		reg = <0xff800000 0x1000>;