| Message ID | 20240904081728.1353260-1-nichen@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 62c9f50eabe080cb07ed5e6c55d1fd38ad04201b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ionic: Convert comma to semicolon | expand |
On 9/4/2024 1:17 AM, Chen Ni wrote: > > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. > No functional change intended. > Compile tested only. > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > index 1ee2f285cb42..528114877677 100644 > --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c > @@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif, > int err = 0; > > ctx.cmd.rx_filter_add = *ac; > - ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD, > - ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index), > + ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD; > + ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index); > > spin_lock_bh(&lif->rx_filters.lock); > f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add); > -- > 2.25.1 > Thanks for catching that. Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 4 Sep 2024 16:17:28 +0800 you wrote: > Replace comma between expressions with semicolons. > > Using a ',' in place of a ';' can have unintended side effects. > Although that is not the case here, it is seems best to use ';' > unless ',' is intended. > > Found by inspection. > No functional change intended. > Compile tested only. > > [...] Here is the summary with links: - [net-next] ionic: Convert comma to semicolon https://git.kernel.org/netdev/net-next/c/62c9f50eabe0 You are awesome, thank you!
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c index 1ee2f285cb42..528114877677 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c @@ -312,8 +312,8 @@ static int ionic_lif_filter_add(struct ionic_lif *lif, int err = 0; ctx.cmd.rx_filter_add = *ac; - ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD, - ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index), + ctx.cmd.rx_filter_add.opcode = IONIC_CMD_RX_FILTER_ADD; + ctx.cmd.rx_filter_add.lif_index = cpu_to_le16(lif->index); spin_lock_bh(&lif->rx_filters.lock); f = ionic_rx_filter_find(lif, &ctx.cmd.rx_filter_add);
Replace comma between expressions with semicolons. Using a ',' in place of a ';' can have unintended side effects. Although that is not the case here, it is seems best to use ';' unless ',' is intended. Found by inspection. No functional change intended. Compile tested only. Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)