| Message ID | 20240903184912.4151926-1-sean.anderson@linux.dev (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d57f7b45945ac0517ff8ea50655f00db6e8d637c |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: cadence: macb: Enable software IRQ coalescing by default | expand |
On Tue, Sep 03, 2024 at 02:49:12PM -0400, Sean Anderson wrote: > This NIC doesn't have hardware IRQ coalescing. Under high load, > interrupts can adversely affect performance. To mitigate this, enable > software IRQ coalescing by default. On my system this increases receive > throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases > interrupts from 69489/sec to 2016/sec, and decreases CPU utilization > from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I > can tell). > > Signed-off-by: Sean Anderson <sean.anderson@linux.dev> Nice performance improvement :) Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 3 Sep 2024 14:49:12 -0400 you wrote: > This NIC doesn't have hardware IRQ coalescing. Under high load, > interrupts can adversely affect performance. To mitigate this, enable > software IRQ coalescing by default. On my system this increases receive > throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases > interrupts from 69489/sec to 2016/sec, and decreases CPU utilization > from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I > can tell). > > [...] Here is the summary with links: - [net-next] net: cadence: macb: Enable software IRQ coalescing by default https://git.kernel.org/netdev/net-next/c/d57f7b45945a You are awesome, thank you!
diff --git a/drivers/net/ethernet/cadence/macb_main.c b/drivers/net/ethernet/cadence/macb_main.c index 127bb3208034..8e1e4b2b2386 100644 --- a/drivers/net/ethernet/cadence/macb_main.c +++ b/drivers/net/ethernet/cadence/macb_main.c @@ -4184,6 +4184,8 @@ static int macb_init(struct platform_device *pdev) dev->ethtool_ops = &macb_ethtool_ops; } + netdev_sw_irq_coalesce_default_on(dev); + dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; /* Set features */
This NIC doesn't have hardware IRQ coalescing. Under high load, interrupts can adversely affect performance. To mitigate this, enable software IRQ coalescing by default. On my system this increases receive throughput with iperf3 from 853 MBit/sec to 934 MBit/s, decreases interrupts from 69489/sec to 2016/sec, and decreases CPU utilization from 27% (4x Cortex-A53) to 14%. Latency is not affected (as far as I can tell). Signed-off-by: Sean Anderson <sean.anderson@linux.dev> --- drivers/net/ethernet/cadence/macb_main.c | 2 ++ 1 file changed, 2 insertions(+)