| Message ID | 20240904111727.1834935-3-haibo.chen@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | few clean up for flexspi driver on imx8ulp and imx8mp | expand |
On 04.09.2024 19:17:23, haibo.chen@nxp.com wrote: > From: Haibo Chen <haibo.chen@nxp.com> > > According to imx8mp RM, the fspi is compatible with the fspi on > imx8mm. So remove this redundant imx8mp compatible string here. > > Fixes: 0467a97367d4 ("spi: fspi: enable fspi driver for on imx8mp") > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > --- > drivers/spi/spi-nxp-fspi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c > index fd1816befcd8..da110188bfed 100644 > --- a/drivers/spi/spi-nxp-fspi.c > +++ b/drivers/spi/spi-nxp-fspi.c > @@ -1286,7 +1286,6 @@ static int nxp_fspi_resume(struct device *dev) > static const struct of_device_id nxp_fspi_dt_ids[] = { > { .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, }, > { .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, }, > - { .compatible = "nxp,imx8mp-fspi", .data = (void *)&imx8mm_data, }, I think this breaks old DT with new driver, doesn't it? > { .compatible = "nxp,imx8qxp-fspi", .data = (void *)&imx8qxp_data, }, > { .compatible = "nxp,imx8dxl-fspi", .data = (void *)&imx8dxl_data, }, > { /* sentinel */ } regards, Marc
On 04/09/2024 13:17, haibo.chen@nxp.com wrote: > From: Haibo Chen <haibo.chen@nxp.com> > > According to imx8mp RM, the fspi is compatible with the fspi on > imx8mm. So remove this redundant imx8mp compatible string here. > > Fixes: 0467a97367d4 ("spi: fspi: enable fspi driver for on imx8mp") > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > --- This breaks users. NAK Best regards, Krzysztof
On Wed, Sep 4, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On 04/09/2024 13:17, haibo.chen@nxp.com wrote: > > From: Haibo Chen <haibo.chen@nxp.com> > > > > According to imx8mp RM, the fspi is compatible with the fspi on > > imx8mm. So remove this redundant imx8mp compatible string here. We'd need to have the device tree compatible fall back to nxp,imx8mm-fspi, but it doesn't, so the driver would never associate itself with nxp,imx8mp-fspi. adam > > > > Fixes: 0467a97367d4 ("spi: fspi: enable fspi driver for on imx8mp") > > Signed-off-by: Haibo Chen <haibo.chen@nxp.com> > > --- > > > This breaks users. > > NAK > > Best regards, > Krzysztof > >
diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index fd1816befcd8..da110188bfed 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -1286,7 +1286,6 @@ static int nxp_fspi_resume(struct device *dev) static const struct of_device_id nxp_fspi_dt_ids[] = { { .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, }, { .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, }, - { .compatible = "nxp,imx8mp-fspi", .data = (void *)&imx8mm_data, }, { .compatible = "nxp,imx8qxp-fspi", .data = (void *)&imx8qxp_data, }, { .compatible = "nxp,imx8dxl-fspi", .data = (void *)&imx8dxl_data, }, { /* sentinel */ }