diff mbox series

[v2,1/3] Fix NanoPi NEO Plus2 regulators

Message ID 20240827-nanopi-neo-plus2-regfix-v2-1-497684ec82c7@gmail.com (mailing list archive)
State Superseded, archived
Headers show
Series Fix regulators and assign them on NanoPi NEO Plus2 | expand

Commit Message

Kryštof Černý Aug. 27, 2024, 9 p.m. UTC 
Added the main board 5 V supply regulator,
a 2.5 V supply regulator for GMAC PHY IO and correct vin-supply elements.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Comments

Andre Przywara Sept. 4, 2024, 4:44 p.m. UTC | #1 
On Tue, 27 Aug 2024 23:00:43 +0200
Kryštof Černý <cleverline1mc@gmail.com> wrote:

Hi,

> Added the main board 5 V supply regulator,
> a 2.5 V supply regulator for GMAC PHY IO and correct vin-supply elements.

thanks for sending this and fixing the DT!

That looks correct when comparing to the schematics:

> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Reviewed-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre

> ---
>  .../dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts   | 25 ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> index b69032c44557..dee4cd82636b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
> @@ -45,16 +45,40 @@ reg_gmac_3v3: gmac-3v3 {
>  		startup-delay-us = <100000>;
>  		enable-active-high;
>  		gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
> +		vin-supply = <&reg_vcc3v3>;
> +	};
> +
> +	reg_gmac_2v5: gmac-2v5 {
> +		/* 2V5 supply for GMAC PHY IO */
> +		compatible = "regulator-fixed";
> +		regulator-name = "gmac-2v5";
> +		regulator-min-microvolt = <2500000>;
> +		regulator-max-microvolt = <2500000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_vcc3v3>;
> +	};
> +
> +	reg_vcc5v: regulator-vcc5v {
> +		/* board 5V supply from micro USB or pin headers */
> +		compatible = "regulator-fixed";
> +		regulator-name = "vcc-5v";
> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +		regulator-always-on;
>  	};
>  
>  	reg_vcc3v3: vcc3v3 {
> +		/* board 3V3 supply by SY8089A */
>  		compatible = "regulator-fixed";
>  		regulator-name = "vcc3v3";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> +		regulator-always-on;
> +		vin-supply = <&reg_vcc5v>;
>  	};
>  
>  	vdd_cpux: gpio-regulator {
> +		/* cpu voltage regulator MP2143DJ */
>  		compatible = "regulator-gpio";
>  		regulator-name = "vdd-cpux";
>  		regulator-type = "voltage";
> @@ -66,6 +90,7 @@ vdd_cpux: gpio-regulator {
>  		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
>  		gpios-states = <0x1>;
>  		states = <1100000 0>, <1300000 1>;
> +		vin-supply = <&reg_vcc5v>;
>  	};
>  
>  	wifi_pwrseq: pwrseq {
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
index b69032c44557..dee4cd82636b 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-neo-plus2.dts
@@ -45,16 +45,40 @@  reg_gmac_3v3: gmac-3v3 {
 		startup-delay-us = <100000>;
 		enable-active-high;
 		gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>;
+		vin-supply = <&reg_vcc3v3>;
+	};
+
+	reg_gmac_2v5: gmac-2v5 {
+		/* 2V5 supply for GMAC PHY IO */
+		compatible = "regulator-fixed";
+		regulator-name = "gmac-2v5";
+		regulator-min-microvolt = <2500000>;
+		regulator-max-microvolt = <2500000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc3v3>;
+	};
+
+	reg_vcc5v: regulator-vcc5v {
+		/* board 5V supply from micro USB or pin headers */
+		compatible = "regulator-fixed";
+		regulator-name = "vcc-5v";
+		regulator-min-microvolt = <5000000>;
+		regulator-max-microvolt = <5000000>;
+		regulator-always-on;
 	};
 
 	reg_vcc3v3: vcc3v3 {
+		/* board 3V3 supply by SY8089A */
 		compatible = "regulator-fixed";
 		regulator-name = "vcc3v3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
+		regulator-always-on;
+		vin-supply = <&reg_vcc5v>;
 	};
 
 	vdd_cpux: gpio-regulator {
+		/* cpu voltage regulator MP2143DJ */
 		compatible = "regulator-gpio";
 		regulator-name = "vdd-cpux";
 		regulator-type = "voltage";
@@ -66,6 +90,7 @@  vdd_cpux: gpio-regulator {
 		gpios = <&r_pio 0 6 GPIO_ACTIVE_HIGH>;
 		gpios-states = <0x1>;
 		states = <1100000 0>, <1300000 1>;
+		vin-supply = <&reg_vcc5v>;
 	};
 
 	wifi_pwrseq: pwrseq {