diff mbox series

[v12,1/5] PM: QoS: Export dev_pm_qos_read_value

Message ID 20240904194229.109886-2-msp@baylibre.com (mailing list archive)
State Handled Elsewhere, archived
Headers show
Series firmware: ti_sci: Introduce system suspend support | expand

Commit Message

Markus Schneider-Pargmann Sept. 4, 2024, 7:42 p.m. UTC
In the ti_sci driver we would like to pass the resume latencies set on
devices to the firmware so it can decide which power mode is the best to
choose. To be able to build a driver using this function as a module,
this function should be exported.

Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
---
 drivers/base/power/qos.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Dhruva Gole Sept. 5, 2024, 6:26 a.m. UTC | #1
On Sep 04, 2024 at 21:42:25 +0200, Markus Schneider-Pargmann wrote:
> In the ti_sci driver we would like to pass the resume latencies set on
> devices to the firmware so it can decide which power mode is the best to
> choose. To be able to build a driver using this function as a module,
> this function should be exported.
> 
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
>  drivers/base/power/qos.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks for this fix Markus,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
Kevin Hilman Sept. 10, 2024, 11:51 p.m. UTC | #2
Markus Schneider-Pargmann <msp@baylibre.com> writes:

> In the ti_sci driver we would like to pass the resume latencies set on
> devices to the firmware so it can decide which power mode is the best to
> choose. To be able to build a driver using this function as a module,
> this function should be exported.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>

Rafael, if there are no objects, feel free to take this one via your
tree.  Thanks!

Kevin

> ---
>  drivers/base/power/qos.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c
> index bd77f6734f14..ff393cba7649 100644
> --- a/drivers/base/power/qos.c
> +++ b/drivers/base/power/qos.c
> @@ -137,6 +137,7 @@ s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type)
>  
>  	return ret;
>  }
> +EXPORT_SYMBOL_GPL(dev_pm_qos_read_value);
>  
>  /**
>   * apply_constraint - Add/modify/remove device PM QoS request.
> -- 
> 2.45.2
diff mbox series

Patch

diff --git a/drivers/base/power/qos.c b/drivers/base/power/qos.c
index bd77f6734f14..ff393cba7649 100644
--- a/drivers/base/power/qos.c
+++ b/drivers/base/power/qos.c
@@ -137,6 +137,7 @@  s32 dev_pm_qos_read_value(struct device *dev, enum dev_pm_qos_req_type type)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(dev_pm_qos_read_value);
 
 /**
  * apply_constraint - Add/modify/remove device PM QoS request.