| Message ID | 20240808074833.1984856-1-john.g.garry@oracle.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | man: Update unit for fsx_extsize and fsx_cowextsize | expand |
On Thu, Aug 08, 2024 at 07:48:33AM +0000, John Garry wrote: > The values in fsx_extsize and fsx_cowextsize are in units of bytes, and not > filesystem blocks, so update. > > In addition, the default cowextsize is 32 filesystem blocks, not 128, so > fix that as well. > > Signed-off-by: John Garry <john.g.garry@oracle.com> Yep, that's been wrong for a while. :( Thanks for fixing the docs, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > > diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2 > index 2c626a7e..25a9ba79 100644 > --- a/man/man2/ioctl_xfs_fsgetxattr.2 > +++ b/man/man2/ioctl_xfs_fsgetxattr.2 > @@ -40,7 +40,7 @@ below for more information. > .PP > .I fsx_extsize > is the preferred extent allocation size for data blocks mapped to this file, > -in units of filesystem blocks. > +in units of bytes. > If this value is zero, the filesystem will choose a default option, which > is currently zero. > If > @@ -62,9 +62,9 @@ is the project ID of this file. > .PP > .I fsx_cowextsize > is the preferred extent allocation size for copy on write operations > -targeting this file, in units of filesystem blocks. > +targeting this file, in units of bytes. > If this field is zero, the filesystem will choose a default option, > -which is currently 128 filesystem blocks. > +which is currently 32 filesystem blocks. > If > .B XFS_IOC_FSSETXATTR > is called with > -- > 2.31.1 > >
On 08/08/2024 08:48, John Garry wrote: > The values in fsx_extsize and fsx_cowextsize are in units of bytes, and not > filesystem blocks, so update. > > In addition, the default cowextsize is 32 filesystem blocks, not 128, so > fix that as well. > > Signed-off-by: John Garry <john.g.garry@oracle.com> Has this change been missed? Cheers, John > > diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2 > index 2c626a7e..25a9ba79 100644 > --- a/man/man2/ioctl_xfs_fsgetxattr.2 > +++ b/man/man2/ioctl_xfs_fsgetxattr.2 > @@ -40,7 +40,7 @@ below for more information. > .PP > .I fsx_extsize > is the preferred extent allocation size for data blocks mapped to this file, > -in units of filesystem blocks. > +in units of bytes. > If this value is zero, the filesystem will choose a default option, which > is currently zero. > If > @@ -62,9 +62,9 @@ is the project ID of this file. > .PP > .I fsx_cowextsize > is the preferred extent allocation size for copy on write operations > -targeting this file, in units of filesystem blocks. > +targeting this file, in units of bytes. > If this field is zero, the filesystem will choose a default option, > -which is currently 128 filesystem blocks. > +which is currently 32 filesystem blocks. > If > .B XFS_IOC_FSSETXATTR > is called with
On Thu, Sep 05, 2024 at 09:15:50AM GMT, John Garry wrote: > On 08/08/2024 08:48, John Garry wrote: > > The values in fsx_extsize and fsx_cowextsize are in units of bytes, and not > > filesystem blocks, so update. > > > > In addition, the default cowextsize is 32 filesystem blocks, not 128, so > > fix that as well. > > > > Signed-off-by: John Garry <john.g.garry@oracle.com> > > Has this change been missed? Yup, I'll add it to the next release. Carlos. > > Cheers, > John > > > > > diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2 > > index 2c626a7e..25a9ba79 100644 > > --- a/man/man2/ioctl_xfs_fsgetxattr.2 > > +++ b/man/man2/ioctl_xfs_fsgetxattr.2 > > @@ -40,7 +40,7 @@ below for more information. > > .PP > > .I fsx_extsize > > is the preferred extent allocation size for data blocks mapped to this file, > > -in units of filesystem blocks. > > +in units of bytes. > > If this value is zero, the filesystem will choose a default option, which > > is currently zero. > > If > > @@ -62,9 +62,9 @@ is the project ID of this file. > > .PP > > .I fsx_cowextsize > > is the preferred extent allocation size for copy on write operations > > -targeting this file, in units of filesystem blocks. > > +targeting this file, in units of bytes. > > If this field is zero, the filesystem will choose a default option, > > -which is currently 128 filesystem blocks. > > +which is currently 32 filesystem blocks. > > If > > .B XFS_IOC_FSSETXATTR > > is called with > >
diff --git a/man/man2/ioctl_xfs_fsgetxattr.2 b/man/man2/ioctl_xfs_fsgetxattr.2 index 2c626a7e..25a9ba79 100644 --- a/man/man2/ioctl_xfs_fsgetxattr.2 +++ b/man/man2/ioctl_xfs_fsgetxattr.2 @@ -40,7 +40,7 @@ below for more information. .PP .I fsx_extsize is the preferred extent allocation size for data blocks mapped to this file, -in units of filesystem blocks. +in units of bytes. If this value is zero, the filesystem will choose a default option, which is currently zero. If @@ -62,9 +62,9 @@ is the project ID of this file. .PP .I fsx_cowextsize is the preferred extent allocation size for copy on write operations -targeting this file, in units of filesystem blocks. +targeting this file, in units of bytes. If this field is zero, the filesystem will choose a default option, -which is currently 128 filesystem blocks. +which is currently 32 filesystem blocks. If .B XFS_IOC_FSSETXATTR is called with
The values in fsx_extsize and fsx_cowextsize are in units of bytes, and not filesystem blocks, so update. In addition, the default cowextsize is 32 filesystem blocks, not 128, so fix that as well. Signed-off-by: John Garry <john.g.garry@oracle.com>