| Message ID | 20240814-google-remove-crtc-index-from-parameter-v1-4-6e179abf9fd4@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vkms: Introduce detailed configuration | expand |
> As the configuration will be used by userspace, add a validator to avoid > creating a broken DRM device This is something I considered to include in my configfs series, however, I'm not sure if the set of rules used to validate a device configuration are already implemented somewhere in the DRM core and we could try to expose them to avoid duplicating them. I'd be nice if someone with a better understanding of the DRM core code could give us some pointers about the best way to implemet these validation rules. Also, if we end up implemeting the rules in VKMS, it'd be nice to print to dmesg some information so the user can figure out what and why failed. > > Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> > --- > drivers/gpu/drm/vkms/vkms_config.c | 5 +++++ > drivers/gpu/drm/vkms/vkms_config.h | 14 ++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c > index ad5d814e6e83..d8348af9587e 100644 > --- a/drivers/gpu/drm/vkms/vkms_config.c > +++ b/drivers/gpu/drm/vkms/vkms_config.c > @@ -21,6 +21,11 @@ void vkms_config_destroy(struct vkms_config *config) > kfree(config); > } > > +bool vkms_config_is_valid(struct vkms_config *config) > +{ > + return true; > +} > + > static int vkms_config_show(struct seq_file *m, void *data) > { > struct drm_debugfs_entry *entry = m->private; > diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms_config.h > index b28483173874..363f5bc8f64b 100644 > --- a/drivers/gpu/drm/vkms/vkms_config.h > +++ b/drivers/gpu/drm/vkms/vkms_config.h > @@ -29,4 +29,18 @@ void vkms_config_register_debugfs(struct vkms_device *vkms_device); > struct vkms_config *vkms_config_create(void); > void vkms_config_destroy(struct vkms_config *config); > > +/** > + * vkms_config_is_valid() - Validate a configuration > + * > + * Check if all the property defined in the configuration are valids. This will return false for > + * example if: > + * - no or many primary planes are present; > + * - the default rotation of a plane is not in its supported rotation; > + * - a CRTC don't have any encoder... > + * > + * @vkms_config: Configuration to validate > + */ > +bool vkms_config_is_valid(struct vkms_config *vkms_config); > + > + > #endif //_VKMS_CONFIG_H >
diff --git a/drivers/gpu/drm/vkms/vkms_config.c b/drivers/gpu/drm/vkms/vkms_config.c index ad5d814e6e83..d8348af9587e 100644 --- a/drivers/gpu/drm/vkms/vkms_config.c +++ b/drivers/gpu/drm/vkms/vkms_config.c @@ -21,6 +21,11 @@ void vkms_config_destroy(struct vkms_config *config) kfree(config); } +bool vkms_config_is_valid(struct vkms_config *config) +{ + return true; +} + static int vkms_config_show(struct seq_file *m, void *data) { struct drm_debugfs_entry *entry = m->private; diff --git a/drivers/gpu/drm/vkms/vkms_config.h b/drivers/gpu/drm/vkms/vkms_config.h index b28483173874..363f5bc8f64b 100644 --- a/drivers/gpu/drm/vkms/vkms_config.h +++ b/drivers/gpu/drm/vkms/vkms_config.h @@ -29,4 +29,18 @@ void vkms_config_register_debugfs(struct vkms_device *vkms_device); struct vkms_config *vkms_config_create(void); void vkms_config_destroy(struct vkms_config *config); +/** + * vkms_config_is_valid() - Validate a configuration + * + * Check if all the property defined in the configuration are valids. This will return false for + * example if: + * - no or many primary planes are present; + * - the default rotation of a plane is not in its supported rotation; + * - a CRTC don't have any encoder... + * + * @vkms_config: Configuration to validate + */ +bool vkms_config_is_valid(struct vkms_config *vkms_config); + + #endif //_VKMS_CONFIG_H
As the configuration will be used by userspace, add a validator to avoid creating a broken DRM device Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com> --- drivers/gpu/drm/vkms/vkms_config.c | 5 +++++ drivers/gpu/drm/vkms/vkms_config.h | 14 ++++++++++++++ 2 files changed, 19 insertions(+)