diff mbox series

ASoC: Intel: skl_hda_dsp_generic: convert comma to semicolon

Message ID 20240905022017.1642550-1-nichen@iscas.ac.cn (mailing list archive)
State Accepted
Commit 813751eaec93bfeb6236aaed99607a44c01b3110
Headers show
Series ASoC: Intel: skl_hda_dsp_generic: convert comma to semicolon | expand

Commit Message

Chen Ni Sept. 5, 2024, 2:20 a.m. UTC
Replace comma between expressions with semicolons.

Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.

Found by inspection.
No functional change intended.
Compile tested only.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 sound/soc/intel/boards/skl_hda_dsp_generic.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Comments

Mark Brown Sept. 5, 2024, 6:42 p.m. UTC | #1
On Thu, 05 Sep 2024 10:20:17 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: Intel: skl_hda_dsp_generic: convert comma to semicolon
      commit: 813751eaec93bfeb6236aaed99607a44c01b3110

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/intel/boards/skl_hda_dsp_generic.c b/sound/soc/intel/boards/skl_hda_dsp_generic.c
index 225867bb3310..8e104874d58c 100644
--- a/sound/soc/intel/boards/skl_hda_dsp_generic.c
+++ b/sound/soc/intel/boards/skl_hda_dsp_generic.c
@@ -217,14 +217,14 @@  static int skl_hda_audio_probe(struct platform_device *pdev)
 		return -ENOMEM;
 
 	card = &ctx->card;
-	card->name = "hda-dsp",
-	card->owner = THIS_MODULE,
-	card->dai_link = skl_hda_be_dai_links,
-	card->dapm_widgets = skl_hda_widgets,
-	card->dapm_routes = skl_hda_map,
-	card->add_dai_link = skl_hda_add_dai_link,
-	card->fully_routed = true,
-	card->late_probe = skl_hda_card_late_probe,
+	card->name = "hda-dsp";
+	card->owner = THIS_MODULE;
+	card->dai_link = skl_hda_be_dai_links;
+	card->dapm_widgets = skl_hda_widgets;
+	card->dapm_routes = skl_hda_map;
+	card->add_dai_link = skl_hda_add_dai_link;
+	card->fully_routed = true;
+	card->late_probe = skl_hda_card_late_probe;
 
 	snd_soc_card_set_drvdata(card, ctx);