mbox series

[v4,0/3] cxl: Pull out mailbox bits to be independent of cxl_dev_state

Message ID 20240905223711.1990186-1-dave.jiang@intel.com
Headers show
Series cxl: Pull out mailbox bits to be independent of cxl_dev_state | expand

Message

Dave Jiang Sept. 5, 2024, 10:35 p.m. UTC
Hi Alejandro,
Please feel free to pull in the patches in this series into your type2 series.
Although I may just pull these into the 6.12 merge window to make things easier
for you.

The patches pulls out the related mailbox bits and form a 'struct cxl_mailbox'. In
v2 Jonathan suggested that we keep cxl_mbox embedded. So I moved it back to be
embedded. For the type2 devices that does not use mailbox, it can just not have
the mailbox struct at all.

v3
- moved the other cxl headers into the linux/cxl directory.
- Moved rcuwait.h header into mailbox.h (Alison)

v4
- Move headers to include/cxl (Dan)
- Move header moving patch to 1/3 (Dan)
- Fix cxl_mailbox_init input param check. (Alison)

---

Dave Jiang (3):
      cxl: move cxl headers to new linux/cxl/ directory
      cxl: Move mailbox related bits to the same context
      cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input

 MAINTAINERS                                |  3 +-
 drivers/acpi/apei/einj-cxl.c               |  2 +-
 drivers/acpi/apei/ghes.c                   |  2 +-
 drivers/cxl/core/mbox.c                    | 91 ++++++++++++++++++++++++++++++++------------------
 drivers/cxl/core/memdev.c                  | 41 +++++++++++++----------
 drivers/cxl/core/port.c                    |  2 +-
 drivers/cxl/cxlmem.h                       | 25 ++++++--------
 drivers/cxl/pci.c                          | 82 ++++++++++++++++++++++++++++++---------------
 drivers/cxl/pmem.c                         | 10 ++++--
 drivers/cxl/security.c                     | 23 +++++++------
 include/{linux/einj-cxl.h => cxl/einj.h}   |  0
 include/{linux/cxl-event.h => cxl/event.h} |  0
 include/cxl/mailbox.h                      | 28 ++++++++++++++++
 tools/testing/cxl/test/mem.c               | 44 ++++++++++++++++++------
 14 files changed, 233 insertions(+), 120 deletions(-)

Comments

Alejandro Lucero Palau Sept. 6, 2024, 7:23 a.m. UTC | #1
On 9/5/24 23:35, Dave Jiang wrote:
> Hi Alejandro,
> Please feel free to pull in the patches in this series into your type2 series.
> Although I may just pull these into the 6.12 merge window to make things easier
> for you.
>
> The patches pulls out the related mailbox bits and form a 'struct cxl_mailbox'. In
> v2 Jonathan suggested that we keep cxl_mbox embedded. So I moved it back to be
> embedded. For the type2 devices that does not use mailbox, it can just not have
> the mailbox struct at all.


I've been using your v2 for my v3, so I'll adjust it to this v4. 
However, I do not think it has an impact on my work since the Type2 
support I'm adding is for our accel case which has not mailbox and 
therefore no accessor for initialising a mailbox from an accel driver is 
added. I guess that will need to wait until another accel driver 
requires it.


> v3
> - moved the other cxl headers into the linux/cxl directory.
> - Moved rcuwait.h header into mailbox.h (Alison)
>
> v4
> - Move headers to include/cxl (Dan)
> - Move header moving patch to 1/3 (Dan)
> - Fix cxl_mailbox_init input param check. (Alison)
>
> ---
>
> Dave Jiang (3):
>        cxl: move cxl headers to new linux/cxl/ directory
>        cxl: Move mailbox related bits to the same context
>        cxl: Convert cxl_internal_send_cmd() to use 'struct cxl_mailbox' as input
>
>   MAINTAINERS                                |  3 +-
>   drivers/acpi/apei/einj-cxl.c               |  2 +-
>   drivers/acpi/apei/ghes.c                   |  2 +-
>   drivers/cxl/core/mbox.c                    | 91 ++++++++++++++++++++++++++++++++------------------
>   drivers/cxl/core/memdev.c                  | 41 +++++++++++++----------
>   drivers/cxl/core/port.c                    |  2 +-
>   drivers/cxl/cxlmem.h                       | 25 ++++++--------
>   drivers/cxl/pci.c                          | 82 ++++++++++++++++++++++++++++++---------------
>   drivers/cxl/pmem.c                         | 10 ++++--
>   drivers/cxl/security.c                     | 23 +++++++------
>   include/{linux/einj-cxl.h => cxl/einj.h}   |  0
>   include/{linux/cxl-event.h => cxl/event.h} |  0
>   include/cxl/mailbox.h                      | 28 ++++++++++++++++
>   tools/testing/cxl/test/mem.c               | 44 ++++++++++++++++++------
>   14 files changed, 233 insertions(+), 120 deletions(-)
>