| Message ID | 00634da33c21269a00844140afc7cc3a2ac1eb4d.1725474584.git.robin.murphy@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] perf/arm-cmn: Clean up unnecessary NUMA_NO_NODE check | expand |
On Wed, 04 Sep 2024 19:41:54 +0100, Robin Murphy wrote: > Checking for NUMA_NO_NODE is a misleading and, on reflection, entirely > unnecessary micro-optimisation. If it ever did happen that an incoming > CPU has no NUMA affinity while the current CPU does, a questionably- > useful PMU migration isn't the biggest thing wrong with that picture... > > Applied to will (for-next/perf), thanks! [1/2] perf/arm-cmn: Clean up unnecessary NUMA_NO_NODE check https://git.kernel.org/will/c/f04b611e6650 [2/2] perf/arm-cmn: Improve format attr printing https://git.kernel.org/will/c/f32efa3e4bba Cheers,
diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index 0266ff041e0b..62d4782da7e4 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -2023,7 +2023,7 @@ static int arm_cmn_pmu_online_cpu(unsigned int cpu, struct hlist_node *cpuhp_nod cmn = hlist_entry_safe(cpuhp_node, struct arm_cmn, cpuhp_node); node = dev_to_node(cmn->dev); - if (node != NUMA_NO_NODE && cpu_to_node(cmn->cpu) != node && cpu_to_node(cpu) == node) + if (cpu_to_node(cmn->cpu) != node && cpu_to_node(cpu) == node) arm_cmn_migrate(cmn, cpu); return 0; }
Checking for NUMA_NO_NODE is a misleading and, on reflection, entirely unnecessary micro-optimisation. If it ever did happen that an incoming CPU has no NUMA affinity while the current CPU does, a questionably- useful PMU migration isn't the biggest thing wrong with that picture... Signed-off-by: Robin Murphy <robin.murphy@arm.com> --- Just a couple more little tweaks here, paying back some co-development from the NI driver. drivers/perf/arm-cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)