| Message ID | 20240906-selftests-mptcp-trailing-ws-v1-0-03421b02c48e@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: mptcp: add time per subtests in TAP output (part 2) | expand |
Hello, On 06/09/2024 19:15, Matthieu Baerts (NGI0) wrote: > After having sent the series with the same name to Netdev, Jakub > realised the TAP parser was not properly handling the spaces around the > directive delimiter (#). I suggest sending these patches to netdev directly, as it was asked by Jakub, and the modifications are simple. New patches for t/upstream: - c46ea800458c: selftests: mptcp: diag: remove trailing whitespace - 7da3b70b8c1a: selftests: mptcp: connect: remove duplicated spaces in TAP output - Results: 9e55e13281d2..b378722dfb2e (export) Tests are now in progress: - export: https://github.com/multipath-tcp/mptcp_net-next/commit/1d732d34a947c22f60161fa2bd1c0e6e9b14f56f/checks Cheers, Matt
Hi Matthieu,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/10742659832
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/c061b56c6627
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=887838
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
After having sent the series with the same name to Netdev, Jakub realised the TAP parser was not properly handling the spaces around the directive delimiter (#). This has been fixed [1], but still better to avoid them. Link: https://github.com/linux-netdev/nipa/pull/38 [1] Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> --- Matthieu Baerts (NGI0) (2): selftests: mptcp: diag: remove trailing whitespace selftests: mptcp: connect: remove duplicated spaces in TAP output tools/testing/selftests/net/mptcp/diag.sh | 2 +- tools/testing/selftests/net/mptcp/mptcp_connect.sh | 14 ++++++++------ 2 files changed, 9 insertions(+), 7 deletions(-) --- base-commit: f876b6643a4a01e34ef370da4e15d7c644585d55 change-id: 20240906-selftests-mptcp-trailing-ws-d62ce8ad81a6 Best regards,