diff mbox series

x86/boot: Remove __packed attribute

Message ID 20240910071838.4545-1-frediano.ziglio@cloud.com (mailing list archive)
State New
Headers show
Series x86/boot: Remove __packed attribute | expand

Commit Message

Frediano Ziglio Sept. 10, 2024, 7:18 a.m. UTC 
The data are properly aligned in trampoline.S.

Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
---
 xen/arch/x86/boot/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Beulich Sept. 10, 2024, 8:48 a.m. UTC | #1 
On 10.09.2024 09:18, Frediano Ziglio wrote:
> The data are properly aligned in trampoline.S.

I think the attribute was added as a precautionary measure. I don't
really mind seeing it dropped, but I wonder if it's getting in the
way somewhere, or whether this is solely tidying along the lines of
personal taste.

Jan

> Signed-off-by: Frediano Ziglio <frediano.ziglio@cloud.com>
> ---
>  xen/arch/x86/boot/cmdline.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c
> index fc9241ede9..aae5a1f04f 100644
> --- a/xen/arch/x86/boot/cmdline.c
> +++ b/xen/arch/x86/boot/cmdline.c
> @@ -38,7 +38,7 @@ asm (
>  #include "video.h"
>  
>  /* Keep in sync with trampoline.S:early_boot_opts label! */
> -typedef struct __packed {
> +typedef struct {
>      uint8_t skip_realmode;
>      uint8_t opt_edd;
>      uint8_t opt_edid;
diff mbox series

Patch

diff --git a/xen/arch/x86/boot/cmdline.c b/xen/arch/x86/boot/cmdline.c
index fc9241ede9..aae5a1f04f 100644
--- a/xen/arch/x86/boot/cmdline.c
+++ b/xen/arch/x86/boot/cmdline.c
@@ -38,7 +38,7 @@  asm (
 #include "video.h"
 
 /* Keep in sync with trampoline.S:early_boot_opts label! */
-typedef struct __packed {
+typedef struct {
     uint8_t skip_realmode;
     uint8_t opt_edd;
     uint8_t opt_edid;