[v2,0/8] serial: qcom-geni: fix console corruption

Message

Johan Hovold Sept. 6, 2024, 1:13 p.m. UTC

This series is a follow-on series to the lockup fixes [1] that addresses
a number of issues in the Qualcomm GENI console code, including corrupt
console output during boot, which is a problem for automated CI testing.

Johan

[1] https://lore.kernel.org/lkml/[e-mail]/

Changes in v2
 - determine poll timeout in set_termios() and avoid hard coding fifo
   size in calculation
 - move fifo drain helper under console ifdef to avoid an unused function
   warning as reported by the kernel test robot
 - drop a redundant active check from fifo drain helper


Douglas Anderson (3):
  soc: qcom: geni-se: add GP_LENGTH/IRQ_EN_SET/IRQ_EN_CLEAR registers
  serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
  serial: qcom-geni: introduce qcom_geni_serial_poll_bitfield()

Johan Hovold (5):
  serial: qcom-geni: fix fifo polling timeout
  serial: qcom-geni: fix false console tx restart
  serial: qcom-geni: fix console corruption
  serial: qcom-geni: disable interrupts during console writes
  serial: qcom-geni: fix polled console corruption

 drivers/tty/serial/qcom_geni_serial.c | 137 +++++++++++++++-----------
 include/linux/soc/qcom/geni-se.h      |   9 ++
 2 files changed, 87 insertions(+), 59 deletions(-)

Comments

Johan Hovold Sept. 11, 2024, 6:19 a.m. UTC | #1

On Fri, Sep 06, 2024 at 03:13:28PM +0200, Johan Hovold wrote:
> This series is a follow-on series to the lockup fixes [1] that addresses
> a number of issues in the Qualcomm GENI console code, including corrupt
> console output during boot, which is a problem for automated CI testing.

> [1] https://lore.kernel.org/lkml/[e-mail]/
> 
> Changes in v2
>  - determine poll timeout in set_termios() and avoid hard coding fifo
>    size in calculation
>  - move fifo drain helper under console ifdef to avoid an unused function
>    warning as reported by the kernel test robot
>  - drop a redundant active check from fifo drain helper
> 
> 
> Douglas Anderson (3):
>   soc: qcom: geni-se: add GP_LENGTH/IRQ_EN_SET/IRQ_EN_CLEAR registers
>   serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
>   serial: qcom-geni: introduce qcom_geni_serial_poll_bitfield()
> 
> Johan Hovold (5):
>   serial: qcom-geni: fix fifo polling timeout
>   serial: qcom-geni: fix false console tx restart
>   serial: qcom-geni: fix console corruption
>   serial: qcom-geni: disable interrupts during console writes
>   serial: qcom-geni: fix polled console corruption

Any chance we could these fixes into 6.12-rc1? 

Johan

Greg Kroah-Hartman Sept. 11, 2024, 7:45 a.m. UTC | #2

On Wed, Sep 11, 2024 at 08:19:06AM +0200, Johan Hovold wrote:
> On Fri, Sep 06, 2024 at 03:13:28PM +0200, Johan Hovold wrote:
> > This series is a follow-on series to the lockup fixes [1] that addresses
> > a number of issues in the Qualcomm GENI console code, including corrupt
> > console output during boot, which is a problem for automated CI testing.
> 
> > [1] https://lore.kernel.org/lkml/[e-mail]/
> > 
> > Changes in v2
> >  - determine poll timeout in set_termios() and avoid hard coding fifo
> >    size in calculation
> >  - move fifo drain helper under console ifdef to avoid an unused function
> >    warning as reported by the kernel test robot
> >  - drop a redundant active check from fifo drain helper
> > 
> > 
> > Douglas Anderson (3):
> >   soc: qcom: geni-se: add GP_LENGTH/IRQ_EN_SET/IRQ_EN_CLEAR registers
> >   serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()
> >   serial: qcom-geni: introduce qcom_geni_serial_poll_bitfield()
> > 
> > Johan Hovold (5):
> >   serial: qcom-geni: fix fifo polling timeout
> >   serial: qcom-geni: fix false console tx restart
> >   serial: qcom-geni: fix console corruption
> >   serial: qcom-geni: disable interrupts during console writes
> >   serial: qcom-geni: fix polled console corruption
> 
> Any chance we could these fixes into 6.12-rc1? 

Yes, let me catch up on patches today and tomorrow, have been traveling
for conferences and have a few days reprieve before the next rounds...

thanks,

greg k-h