| Message ID | 20240910120635.115266-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | af647fe240a9c9ea5f63bb9194b971049098955e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [next,V2] qlcnic: make read-only const array key static | expand |
On Tue, Sep 10, 2024 at 01:06:35PM +0100, Colin Ian King wrote: > Don't populate the const read-only array key on the stack at > run time, instead make it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > --- > > V2: re-order declarations for reverse christmas tree layout Thanks for the update. Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 10 Sep 2024 13:06:35 +0100 you wrote: > Don't populate the const read-only array key on the stack at > run time, instead make it static. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > --- > > [...] Here is the summary with links: - [next,V2] qlcnic: make read-only const array key static https://git.kernel.org/netdev/net-next/c/af647fe240a9 You are awesome, thank you!
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c index bcef8ab715bf..d7cdea8f604d 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c @@ -2042,12 +2042,14 @@ int qlcnic_83xx_config_hw_lro(struct qlcnic_adapter *adapter, int mode) int qlcnic_83xx_config_rss(struct qlcnic_adapter *adapter, int enable) { - int err; - u32 word; struct qlcnic_cmd_args cmd; - const u64 key[] = { 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL, - 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL, - 0x255b0ec26d5a56daULL }; + static const u64 key[] = { + 0xbeac01fa6a42b73bULL, 0x8030f20c77cb2da3ULL, + 0xae7b30b4d0ca2bcbULL, 0x43a38fb04167253dULL, + 0x255b0ec26d5a56daULL + }; + u32 word; + int err; err = qlcnic_alloc_mbx_args(&cmd, adapter, QLCNIC_CMD_CONFIGURE_RSS); if (err)
Don't populate the const read-only array key on the stack at run time, instead make it static. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- V2: re-order declarations for reverse christmas tree layout --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)