diff mbox series

[f2fs-dev,v1,1/2] f2fs: remove unused parameters

Message ID 1726022421-58677-2-git-send-email-liuderong@oppo.com (mailing list archive)
State Superseded
Headers show
Series f2fs: modify the calculation method of mtime | expand

Commit Message

liuderong--- via Linux-f2fs-devel Sept. 11, 2024, 2:40 a.m. UTC 
From: liuderong <liuderong@oppo.com>

Remove unused parameter segno from f2fs_usable_segs_in_sec.

Signed-off-by: liuderong <liuderong@oppo.com>
---
 fs/f2fs/f2fs.h    | 3 +--
 fs/f2fs/gc.c      | 6 +++---
 fs/f2fs/segment.c | 3 +--
 fs/f2fs/segment.h | 4 ++--
 4 files changed, 7 insertions(+), 9 deletions(-)

--
2.7.4

Comments

Chao Yu Sept. 11, 2024, 10:11 a.m. UTC | #1 
On 2024/9/11 10:40, liuderong@oppo.com wrote:
> From: liuderong <liuderong@oppo.com>
> 
> Remove unused parameter segno from f2fs_usable_segs_in_sec.
> 
> Signed-off-by: liuderong <liuderong@oppo.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
diff mbox series

Patch

diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index ac19c61..4dcdcdd 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -3759,8 +3759,7 @@  void f2fs_destroy_segment_manager_caches(void);
 int f2fs_rw_hint_to_seg_type(struct f2fs_sb_info *sbi, enum rw_hint hint);
 enum rw_hint f2fs_io_type_to_rw_hint(struct f2fs_sb_info *sbi,
                        enum page_type type, enum temp_type temp);
-unsigned int f2fs_usable_segs_in_sec(struct f2fs_sb_info *sbi,
-                       unsigned int segno);
+unsigned int f2fs_usable_segs_in_sec(struct f2fs_sb_info *sbi);
 unsigned int f2fs_usable_blks_in_seg(struct f2fs_sb_info *sbi,
                        unsigned int segno);

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 724bbcb..6299639 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -339,7 +339,7 @@  static unsigned int get_cb_cost(struct f2fs_sb_info *sbi, unsigned int segno)
        unsigned char age = 0;
        unsigned char u;
        unsigned int i;
-       unsigned int usable_segs_per_sec = f2fs_usable_segs_in_sec(sbi, segno);
+       unsigned int usable_segs_per_sec = f2fs_usable_segs_in_sec(sbi);

        for (i = 0; i < usable_segs_per_sec; i++)
                mtime += get_seg_entry(sbi, start + i)->mtime;
@@ -1707,7 +1707,7 @@  static int do_garbage_collect(struct f2fs_sb_info *sbi,
         */
        if (f2fs_sb_has_blkzoned(sbi))
                end_segno -= SEGS_PER_SEC(sbi) -
-                                       f2fs_usable_segs_in_sec(sbi, segno);
+                                       f2fs_usable_segs_in_sec(sbi);

        sanity_check_seg_type(sbi, get_seg_entry(sbi, segno)->type);

@@ -1881,7 +1881,7 @@  int f2fs_gc(struct f2fs_sb_info *sbi, struct f2fs_gc_control *gc_control)

        total_freed += seg_freed;

-       if (seg_freed == f2fs_usable_segs_in_sec(sbi, segno)) {
+       if (seg_freed == f2fs_usable_segs_in_sec(sbi)) {
                sec_freed++;
                total_sec_freed++;
        }
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 78c3198..6627394 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -5381,8 +5381,7 @@  unsigned int f2fs_usable_blks_in_seg(struct f2fs_sb_info *sbi,
        return BLKS_PER_SEG(sbi);
 }

-unsigned int f2fs_usable_segs_in_sec(struct f2fs_sb_info *sbi,
-                                       unsigned int segno)
+unsigned int f2fs_usable_segs_in_sec(struct f2fs_sb_info *sbi)
 {
        if (f2fs_sb_has_blkzoned(sbi))
                return CAP_SEGS_PER_SEC(sbi);
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index bfc01a5..9e61ded 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -430,7 +430,7 @@  static inline void __set_free(struct f2fs_sb_info *sbi, unsigned int segno)
        unsigned int secno = GET_SEC_FROM_SEG(sbi, segno);
        unsigned int start_segno = GET_SEG_FROM_SEC(sbi, secno);
        unsigned int next;
-       unsigned int usable_segs = f2fs_usable_segs_in_sec(sbi, segno);
+       unsigned int usable_segs = f2fs_usable_segs_in_sec(sbi);

        spin_lock(&free_i->segmap_lock);
        clear_bit(segno, free_i->free_segmap);
@@ -464,7 +464,7 @@  static inline void __set_test_and_free(struct f2fs_sb_info *sbi,
        unsigned int secno = GET_SEC_FROM_SEG(sbi, segno);
        unsigned int start_segno = GET_SEG_FROM_SEC(sbi, secno);
        unsigned int next;
-       unsigned int usable_segs = f2fs_usable_segs_in_sec(sbi, segno);
+       unsigned int usable_segs = f2fs_usable_segs_in_sec(sbi);

        spin_lock(&free_i->segmap_lock);
        if (test_and_clear_bit(segno, free_i->free_segmap)) {