| Message ID | 20240909111535.528624-6-fshao@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Several fixes and supports for MediaTek MT8188 SoC | expand |
Il 09/09/24 13:14, Fei Shao ha scritto: > Add the missing clock-names property for GCE nodes to fix errors from > `make CHECK_DTBS=y mediatek/mt8188-evb.dtb`. I've sent a patch [1] relaxing the requirement for clock-names in the binding. There's no reason to make clock-names mandatory, as there is and there always will be one single clock for each GCE mailbox - and also the driver is not trying to get the clock by name, but rather gets the clock at index 0 anyway. Please drop this patch. Cheers, Angelo [1]: https://lore.kernel.org/all/20240911104327.123602-1-angelogioacchino.delregno@collabora.com/ > > Signed-off-by: Fei Shao <fshao@chromium.org> > --- > > arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > index 445d30eee2a1..2900d78b7ceb 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi > @@ -1316,6 +1316,7 @@ gce0: mailbox@10320000 { > interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH 0>; > #mbox-cells = <2>; > clocks = <&infracfg_ao CLK_INFRA_AO_GCE>; > + clock-names = "gce"; > }; > > gce1: mailbox@10330000 { > @@ -1324,6 +1325,7 @@ gce1: mailbox@10330000 { > interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH 0>; > #mbox-cells = <2>; > clocks = <&infracfg_ao CLK_INFRA_AO_GCE2>; > + clock-names = "gce"; > }; > > scp: scp@10500000 {
On Wed, Sep 11, 2024 at 6:46 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 09/09/24 13:14, Fei Shao ha scritto: > > Add the missing clock-names property for GCE nodes to fix errors from > > `make CHECK_DTBS=y mediatek/mt8188-evb.dtb`. > > I've sent a patch [1] relaxing the requirement for clock-names in the binding. > There's no reason to make clock-names mandatory, as there is and there always > will be one single clock for each GCE mailbox - and also the driver is not > trying to get the clock by name, but rather gets the clock at index 0 anyway. > > Please drop this patch. Acknowledged. I'll drop this in the next revision. Thanks, Fei
diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi index 445d30eee2a1..2900d78b7ceb 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi @@ -1316,6 +1316,7 @@ gce0: mailbox@10320000 { interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH 0>; #mbox-cells = <2>; clocks = <&infracfg_ao CLK_INFRA_AO_GCE>; + clock-names = "gce"; }; gce1: mailbox@10330000 { @@ -1324,6 +1325,7 @@ gce1: mailbox@10330000 { interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH 0>; #mbox-cells = <2>; clocks = <&infracfg_ao CLK_INFRA_AO_GCE2>; + clock-names = "gce"; }; scp: scp@10500000 {
Add the missing clock-names property for GCE nodes to fix errors from `make CHECK_DTBS=y mediatek/mt8188-evb.dtb`. Signed-off-by: Fei Shao <fshao@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8188.dtsi | 2 ++ 1 file changed, 2 insertions(+)