| Message ID | 20240907031009.3591057-2-lizetao1@huawei.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [-next,v2] platform/olpc: Remove redundant null pointer checks in olpc_ec_setup_debugfs() | expand |
Hi, On 9/7/24 5:09 AM, Li Zetao wrote: > Since the debugfs_create_dir() never returns a null pointer, checking > the return value for a null pointer is redundant. Since > debugfs_create_file() can deal with a ERR_PTR() style pointer, drop > the check. > > Signed-off-by: Li Zetao <lizetao1@huawei.com> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > v1 -> v2: > v1: > https://lore.kernel.org/all/20240903143714.2004947-1-lizetao1@huawei.com/ > > drivers/platform/olpc/olpc-ec.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c > index 921520475ff6..48e9861bb571 100644 > --- a/drivers/platform/olpc/olpc-ec.c > +++ b/drivers/platform/olpc/olpc-ec.c > @@ -332,9 +332,6 @@ static struct dentry *olpc_ec_setup_debugfs(void) > struct dentry *dbgfs_dir; > > dbgfs_dir = debugfs_create_dir("olpc-ec", NULL); > - if (IS_ERR_OR_NULL(dbgfs_dir)) > - return NULL; > - > debugfs_create_file("cmd", 0600, dbgfs_dir, NULL, &ec_dbgfs_ops); > > return dbgfs_dir;
diff --git a/drivers/platform/olpc/olpc-ec.c b/drivers/platform/olpc/olpc-ec.c index 921520475ff6..48e9861bb571 100644 --- a/drivers/platform/olpc/olpc-ec.c +++ b/drivers/platform/olpc/olpc-ec.c @@ -332,9 +332,6 @@ static struct dentry *olpc_ec_setup_debugfs(void) struct dentry *dbgfs_dir; dbgfs_dir = debugfs_create_dir("olpc-ec", NULL); - if (IS_ERR_OR_NULL(dbgfs_dir)) - return NULL; - debugfs_create_file("cmd", 0600, dbgfs_dir, NULL, &ec_dbgfs_ops); return dbgfs_dir;
Since the debugfs_create_dir() never returns a null pointer, checking the return value for a null pointer is redundant. Since debugfs_create_file() can deal with a ERR_PTR() style pointer, drop the check. Signed-off-by: Li Zetao <lizetao1@huawei.com> --- v1 -> v2: v1: https://lore.kernel.org/all/20240903143714.2004947-1-lizetao1@huawei.com/ drivers/platform/olpc/olpc-ec.c | 3 --- 1 file changed, 3 deletions(-)