[0/3] Revert "virtio_net: rx enable premapped mode by default"

Message

Xuan Zhuo Sept. 6, 2024, 12:31 p.m. UTC

Regression: http://lore.kernel.org/all/[e-mail]

I still think that the patch can fix the problem, I hope Darren can re-test it
or give me more info.

    http://lore.kernel.org/all/[e-mail]

If that can not work or Darren can not reply in time, Michael you can try this
patch set.

Thanks.

Xuan Zhuo (3):
  Revert "virtio_net: rx remove premapped failover code"
  Revert "virtio_net: big mode skip the unmap check"
  virtio_net: disable premapped mode by default

 drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
 1 file changed, 46 insertions(+), 49 deletions(-)

--
2.32.0.3.g01195cf9f

Comments

Michael S. Tsirkin Sept. 8, 2024, 7:38 p.m. UTC | #1

On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> Regression: http://lore.kernel.org/all/[e-mail]
> 
> I still think that the patch can fix the problem, I hope Darren can re-test it
> or give me more info.
> 
>     http://lore.kernel.org/all/[e-mail]
> 
> If that can not work or Darren can not reply in time, Michael you can try this
> patch set.


Acked-by: Michael S. Tsirkin <[e-mail]>
Tested-by: Takero Funaki <[e-mail]>


> Thanks.
> 
> Xuan Zhuo (3):
>   Revert "virtio_net: rx remove premapped failover code"
>   Revert "virtio_net: big mode skip the unmap check"
>   virtio_net: disable premapped mode by default
> 
>  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>  1 file changed, 46 insertions(+), 49 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f
>

Michael S. Tsirkin Sept. 10, 2024, 12:12 p.m. UTC | #2

On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> Regression: http://lore.kernel.org/all/[e-mail]
> 
> I still think that the patch can fix the problem, I hope Darren can re-test it
> or give me more info.
> 
>     http://lore.kernel.org/all/[e-mail]
> 
> If that can not work or Darren can not reply in time, Michael you can try this
> patch set.

Just making sure netdev maintainers see this, this patch is for net.

> Thanks.
> 
> Xuan Zhuo (3):
>   Revert "virtio_net: rx remove premapped failover code"
>   Revert "virtio_net: big mode skip the unmap check"
>   virtio_net: disable premapped mode by default
> 
>  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>  1 file changed, 46 insertions(+), 49 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f

Jakub Kicinski Sept. 10, 2024, 4:03 p.m. UTC | #3

On Tue, 10 Sep 2024 08:12:06 -0400 Michael S. Tsirkin wrote:
> Just making sure netdev maintainers see this, this patch is for net.

Got it, thanks! I'll be applying it shortly.

[e-mail] Sept. 10, 2024, 4:50 p.m. UTC | #4

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <[e-mail]>:

On Fri,  6 Sep 2024 20:31:34 +0800 you wrote:
> Regression: http://lore.kernel.org/all/[e-mail]
> 
> I still think that the patch can fix the problem, I hope Darren can re-test it
> or give me more info.
> 
>     http://lore.kernel.org/all/[e-mail]
> 
> [...]

Here is the summary with links:
  - [1/3] Revert "virtio_net: rx remove premapped failover code"
    https://git.kernel.org/netdev/net/c/dc4547fbba87
  - [2/3] Revert "virtio_net: big mode skip the unmap check"
    https://git.kernel.org/netdev/net/c/38eef112a8e5
  - [3/3] virtio_net: disable premapped mode by default
    https://git.kernel.org/netdev/net/c/111fc9f517cb

You are awesome, thank you!

Darren Kenny Sept. 11, 2024, 2:18 p.m. UTC | #5

For the record, I got a chance to test these changes and confirmed that
they resolved the issue for me when applied on 6.11-rc7.

Tested-by: Darren Kenny <[e-mail]>

Thanks,

Darren.

PS - I'll try get to looking at the other potential fix when I have time.

On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
>> Regression: http://lore.kernel.org/all/[e-mail]
>> 
>> I still think that the patch can fix the problem, I hope Darren can re-test it
>> or give me more info.
>> 
>>     http://lore.kernel.org/all/[e-mail]
>> 
>> If that can not work or Darren can not reply in time, Michael you can try this
>> patch set.
>
> Just making sure netdev maintainers see this, this patch is for net.
>
>> Thanks.
>> 
>> Xuan Zhuo (3):
>>   Revert "virtio_net: rx remove premapped failover code"
>>   Revert "virtio_net: big mode skip the unmap check"
>>   virtio_net: disable premapped mode by default
>> 
>>  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>>  1 file changed, 46 insertions(+), 49 deletions(-)
>> 
>> --
>> 2.32.0.3.g01195cf9f

Michael S. Tsirkin Sept. 11, 2024, 2:22 p.m. UTC | #6

Thanks a lot!
Could you retest Xuan Zhuo original patch just to make sure it does
not fix the issue?

On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
> For the record, I got a chance to test these changes and confirmed that
> they resolved the issue for me when applied on 6.11-rc7.
> 
> Tested-by: Darren Kenny <[e-mail]>
> 
> Thanks,
> 
> Darren.
> 
> PS - I'll try get to looking at the other potential fix when I have time.
> 
> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
> > On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> >> Regression: http://lore.kernel.org/all/[e-mail]
> >> 
> >> I still think that the patch can fix the problem, I hope Darren can re-test it
> >> or give me more info.
> >> 
> >>     http://lore.kernel.org/all/[e-mail]
> >> 
> >> If that can not work or Darren can not reply in time, Michael you can try this
> >> patch set.
> >
> > Just making sure netdev maintainers see this, this patch is for net.
> >
> >> Thanks.
> >> 
> >> Xuan Zhuo (3):
> >>   Revert "virtio_net: rx remove premapped failover code"
> >>   Revert "virtio_net: big mode skip the unmap check"
> >>   virtio_net: disable premapped mode by default
> >> 
> >>  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
> >>  1 file changed, 46 insertions(+), 49 deletions(-)
> >> 
> >> --
> >> 2.32.0.3.g01195cf9f

Si-Wei Liu Sept. 11, 2024, 7:30 p.m. UTC | #7

On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote:
> Thanks a lot!
> Could you retest Xuan Zhuo original patch
Which one? I thought Darren already did so?

-Siwei
>   just to make sure it does
> not fix the issue?
>
> On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
>> For the record, I got a chance to test these changes and confirmed that
>> they resolved the issue for me when applied on 6.11-rc7.
>>
>> Tested-by: Darren Kenny <[e-mail]>
>>
>> Thanks,
>>
>> Darren.
>>
>> PS - I'll try get to looking at the other potential fix when I have time.
>>
>> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
>>> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
>>>> Regression: http://lore.kernel.org/all/[e-mail]
>>>>
>>>> I still think that the patch can fix the problem, I hope Darren can re-test it
>>>> or give me more info.
>>>>
>>>>      http://lore.kernel.org/all/[e-mail]
>>>>
>>>> If that can not work or Darren can not reply in time, Michael you can try this
>>>> patch set.
>>> Just making sure netdev maintainers see this, this patch is for net.
>>>
>>>> Thanks.
>>>>
>>>> Xuan Zhuo (3):
>>>>    Revert "virtio_net: rx remove premapped failover code"
>>>>    Revert "virtio_net: big mode skip the unmap check"
>>>>    virtio_net: disable premapped mode by default
>>>>
>>>>   drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>>>>   1 file changed, 46 insertions(+), 49 deletions(-)
>>>>
>>>> --
>>>> 2.32.0.3.g01195cf9f

Xuan Zhuo Sept. 12, 2024, 1:49 a.m. UTC | #8

On Wed, 11 Sep 2024 12:30:49 -0700, "Si-Wei Liu" <[e-mail]> wrote:
>
>
> On 9/11/2024 7:22 AM, Michael S. Tsirkin wrote:
> > Thanks a lot!
> > Could you retest Xuan Zhuo original patch
> Which one? I thought Darren already did so?


This one[1].

Now, we revert these patches to disable premapped mode by default.
But the bug still exists, if we enable the premapped mode manually,
the bug works again.

[1] was attempted to correct the bug. However, Darren reported that it did not
work. On the other hand, Jason, Takero, and me tested it and found that
it worked for we.

So I ask Darren to retest [1] if he has the time.

 [1].http://lore.kernel.org/all/[e-mail]

Thanks.


>
> -Siwei
> >   just to make sure it does
> > not fix the issue?
> >
> > On Wed, Sep 11, 2024 at 03:18:55PM +0100, Darren Kenny wrote:
> >> For the record, I got a chance to test these changes and confirmed that
> >> they resolved the issue for me when applied on 6.11-rc7.
> >>
> >> Tested-by: Darren Kenny <[e-mail]>
> >>
> >> Thanks,
> >>
> >> Darren.
> >>
> >> PS - I'll try get to looking at the other potential fix when I have time.
> >>
> >> On Tuesday, 2024-09-10 at 08:12:06 -04, Michael S. Tsirkin wrote:
> >>> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> >>>> Regression: http://lore.kernel.org/all/[e-mail]
> >>>>
> >>>> I still think that the patch can fix the problem, I hope Darren can re-test it
> >>>> or give me more info.
> >>>>
> >>>>      http://lore.kernel.org/all/[e-mail]
> >>>>
> >>>> If that can not work or Darren can not reply in time, Michael you can try this
> >>>> patch set.
> >>> Just making sure netdev maintainers see this, this patch is for net.
> >>>
> >>>> Thanks.
> >>>>
> >>>> Xuan Zhuo (3):
> >>>>    Revert "virtio_net: rx remove premapped failover code"
> >>>>    Revert "virtio_net: big mode skip the unmap check"
> >>>>    virtio_net: disable premapped mode by default
> >>>>
> >>>>   drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
> >>>>   1 file changed, 46 insertions(+), 49 deletions(-)
> >>>>
> >>>> --
> >>>> 2.32.0.3.g01195cf9f
>

Michael S. Tsirkin Oct. 9, 2024, 9:29 a.m. UTC | #9

On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> Regression: http://lore.kernel.org/all/[e-mail]
> 
> I still think that the patch can fix the problem, I hope Darren can re-test it
> or give me more info.
> 
>     http://lore.kernel.org/all/[e-mail]
> 
> If that can not work or Darren can not reply in time, Michael you can try this
> patch set.
> 
> Thanks.

It's been a month - were you going to post patches fixing bugs in premap
and then re-enabling this?

Thanks!


> Xuan Zhuo (3):
>   Revert "virtio_net: rx remove premapped failover code"
>   Revert "virtio_net: big mode skip the unmap check"
>   virtio_net: disable premapped mode by default
> 
>  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
>  1 file changed, 46 insertions(+), 49 deletions(-)
> 
> --
> 2.32.0.3.g01195cf9f
>

Xuan Zhuo Oct. 9, 2024, 10 a.m. UTC | #10

On Wed, 9 Oct 2024 05:29:35 -0400, "Michael S. Tsirkin" <[e-mail]> wrote:
> On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> > Regression: http://lore.kernel.org/all/[e-mail]
> >
> > I still think that the patch can fix the problem, I hope Darren can re-test it
> > or give me more info.
> >
> >     http://lore.kernel.org/all/[e-mail]
> >
> > If that can not work or Darren can not reply in time, Michael you can try this
> > patch set.
> >
> > Thanks.
>
> It's been a month - were you going to post patches fixing bugs in premap
> and then re-enabling this?

[1] was tried to fix the bug in premapped mode.

We all wait the re-test from Darren.

But Jason and Takero have tested it.

If you do not want to wait Darren, we can discuss [1] or add it to your next
branch for more test.

Thanks.

[1]: http://lore.kernel.org/all/[e-mail]


>
> Thanks!
>
>
> > Xuan Zhuo (3):
> >   Revert "virtio_net: rx remove premapped failover code"
> >   Revert "virtio_net: big mode skip the unmap check"
> >   virtio_net: disable premapped mode by default
> >
> >  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
> >  1 file changed, 46 insertions(+), 49 deletions(-)
> >
> > --
> > 2.32.0.3.g01195cf9f
> >
>

Michael S. Tsirkin Oct. 9, 2024, 10:23 a.m. UTC | #11

On Wed, Oct 09, 2024 at 06:00:47PM +0800, Xuan Zhuo wrote:
> On Wed, 9 Oct 2024 05:29:35 -0400, "Michael S. Tsirkin" <[e-mail]> wrote:
> > On Fri, Sep 06, 2024 at 08:31:34PM +0800, Xuan Zhuo wrote:
> > > Regression: http://lore.kernel.org/all/[e-mail]
> > >
> > > I still think that the patch can fix the problem, I hope Darren can re-test it
> > > or give me more info.
> > >
> > >     http://lore.kernel.org/all/[e-mail]
> > >
> > > If that can not work or Darren can not reply in time, Michael you can try this
> > > patch set.
> > >
> > > Thanks.
> >
> > It's been a month - were you going to post patches fixing bugs in premap
> > and then re-enabling this?
> 
> [1] was tried to fix the bug in premapped mode.
> 
> We all wait the re-test from Darren.
> 
> But Jason and Takero have tested it.
> 
> If you do not want to wait Darren, we can discuss [1] or add it to your next
> branch for more test.
> 
> Thanks.
> 
> [1]: http://lore.kernel.org/all/[e-mail]
> 
> 
> >
> > Thanks!
> >
> >
> > > Xuan Zhuo (3):
> > >   Revert "virtio_net: rx remove premapped failover code"
> > >   Revert "virtio_net: big mode skip the unmap check"
> > >   virtio_net: disable premapped mode by default
> > >
> > >  drivers/net/virtio_net.c | 95 +++++++++++++++++++---------------------
> > >  1 file changed, 46 insertions(+), 49 deletions(-)
> > >
> > > --
> > > 2.32.0.3.g01195cf9f
> > >
> >

I suggest you post a patchset you want me to apply on top of master.