| Message ID | 20240910095629.570674-1-jiawenwu@trustnetic.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 077ee7e6b13a2b6668196ed01a22023549e19381 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: libwx: fix number of Rx and Tx descriptors | expand |
On Tue, Sep 10, 2024 at 05:56:29PM +0800, Jiawen Wu wrote: > The number of transmit and receive descriptors must be a multiple of 128 > due to the hardware limitation. If it is set to a multiple of 8 instead of > a multiple 128, the queues will easily be hung. > > Cc: stable@vger.kernel.org > Fixes: 883b5984a5d2 ("net: wangxun: add ethtool_ops for ring parameters") > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 10 Sep 2024 17:56:29 +0800 you wrote: > The number of transmit and receive descriptors must be a multiple of 128 > due to the hardware limitation. If it is set to a multiple of 8 instead of > a multiple 128, the queues will easily be hung. > > Cc: stable@vger.kernel.org > Fixes: 883b5984a5d2 ("net: wangxun: add ethtool_ops for ring parameters") > Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> > > [...] Here is the summary with links: - [net] net: libwx: fix number of Rx and Tx descriptors https://git.kernel.org/netdev/net/c/077ee7e6b13a You are awesome, thank you!
diff --git a/drivers/net/ethernet/wangxun/libwx/wx_type.h b/drivers/net/ethernet/wangxun/libwx/wx_type.h index 1d57b047817b..b54bffda027b 100644 --- a/drivers/net/ethernet/wangxun/libwx/wx_type.h +++ b/drivers/net/ethernet/wangxun/libwx/wx_type.h @@ -426,9 +426,9 @@ enum WX_MSCA_CMD_value { #define WX_MIN_RXD 128 #define WX_MIN_TXD 128 -/* Number of Transmit and Receive Descriptors must be a multiple of 8 */ -#define WX_REQ_RX_DESCRIPTOR_MULTIPLE 8 -#define WX_REQ_TX_DESCRIPTOR_MULTIPLE 8 +/* Number of Transmit and Receive Descriptors must be a multiple of 128 */ +#define WX_REQ_RX_DESCRIPTOR_MULTIPLE 128 +#define WX_REQ_TX_DESCRIPTOR_MULTIPLE 128 #define WX_MAX_JUMBO_FRAME_SIZE 9432 /* max payload 9414 */ #define VMDQ_P(p) p
The number of transmit and receive descriptors must be a multiple of 128 due to the hardware limitation. If it is set to a multiple of 8 instead of a multiple 128, the queues will easily be hung. Cc: stable@vger.kernel.org Fixes: 883b5984a5d2 ("net: wangxun: add ethtool_ops for ring parameters") Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com> --- drivers/net/ethernet/wangxun/libwx/wx_type.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)